Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty details panel after stopping container #693

Closed
2opremio opened this issue Nov 23, 2015 · 7 comments
Closed

Empty details panel after stopping container #693

2opremio opened this issue Nov 23, 2015 · 7 comments
Assignees
Milestone

Comments

@2opremio
Copy link
Contributor

Either the details panel should be implicitly hidden after stopping a container or we should show a friendlier message such as, "container stopped"

Before stopping:

screen shot 2015-11-23 at 22 54 16

After stopping:

screen shot 2015-11-23 at 22 54 30

@2opremio
Copy link
Contributor Author

In fact, shouldn't we still be getting status info about the container? Like that it's stopped and its corresponding image?

@tomwilkie
Copy link
Contributor

This is happening as we filter out stopped containers, and we don't show
details for nodes that disappear. Ie when you stop a container the node
disspears.

On Tuesday, 24 November 2015, Alfonso Acosta notifications@github.com
wrote:

In fact, shouldn't we still be getting status info about the container?
Like that it's stopped and that the image it's running?


Reply to this email directly or view it on GitHub
#693 (comment).

@2opremio
Copy link
Contributor Author

@tomwilkie makes sense, then I guess we should hide the details panel when we stop it.

@tomwilkie
Copy link
Contributor

We used to do that, but an issue was filled saying that it was unintuitive
behaviour, if I recall correctly.

I think current behaviour is surprising too, so this does need a rethink.
We could not filter out stopped container by default, but that has the
potential to fill up the view with lots of unconnected containers (docker
does tend to leave lots of stopped containers around). We could have a
grace period, and show containers that were stopped in the last 30s, for
instance, but that could be even more confusing. Any other ideas?

On Tuesday, 24 November 2015, Alfonso Acosta notifications@github.com
wrote:

@tomwilkie https://github.com/tomwilkie makes sense, then I guess we
should hide the details panel when we stop it.


Reply to this email directly or view it on
#693 (comment)

@2opremio
Copy link
Contributor Author

Can't the details panel still have access to the details of the container so long as it's open?

@tomwilkie
Copy link
Contributor

Right now the details panel can only show details of nodes in the current
view (ie not ones which have been filtered out). We could change that,
and make the endpoint for fetching node details ignore the filters. This
could be unintuitive for other reasons, but does sound least worse.
@davkal, thoughts?

On Tuesday, 24 November 2015, Alfonso Acosta notifications@github.com
wrote:

Can't the details panel still have access to the details of the container
so long as it's open?


Reply to this email directly or view it on GitHub
#693 (comment).

@tomwilkie
Copy link
Contributor

@davkal mind if I take this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants