Don't apply filters to node endpoints & update details panel logic #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch that node which dissappear from the topology (eg when they are stopped) don't dissapear from the details panel.
|
We're still sending the topology options as a request parameter: Should that be removed too? |
|
Yes it can be now. Do you mind doing that? |
| if (details) { | ||
| return this.renderDetails(); | ||
| } | ||
|
|
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Test failures are fixed on master. Can I merge this now? |
|
LGTM, then. |
tomwilkie
added a commit
that referenced
this pull request
Nov 30, 2015
Don't apply filters to node endpoints & update details panel logic
|
Looks like I came too late: 40f5040 (removes options query from node details request) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such that node which disappear from the topology (eg when they are stopped) don't disappear from the details panel.
Fixes #693