Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcode 127.0.0.1 as loopback IP for default target #2103

Merged
merged 1 commit into from
Dec 21, 2016
Merged

Hardcode 127.0.0.1 as loopback IP for default target #2103

merged 1 commit into from
Dec 21, 2016

Conversation

2opremio
Copy link
Contributor

Fixes #2102

@2opremio 2opremio requested a review from ekimekim December 20, 2016 14:55
ekimekim
ekimekim approved these changes Dec 20, 2016
View reviewed changes
Copy link
Contributor

@ekimekim ekimekim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a comment explaining why we're hard-coding the ip? lgtm regardless.

@2opremio 2opremio merged commit 00c4a7c into master Dec 21, 2016
@2opremio 2opremio deleted the 2102-hardcode-loopback-ip branch February 13, 2017 12:17
@bboreham bboreham mentioned this pull request Jun 1, 2017
Merged
@bboreham bboreham mentioned this pull request Jun 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekimekim ekimekim ekimekim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2opremio @ekimekim