refactor(logs): Add reporter name to error logs. #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Adding reporter name to logs improves tracing of error. 2. Capitalize first letter of error log. Fixes weaveworks#3306 Signed-off-by: Prince Rachit Sinha <prince.rachit@mayadata.io>
|
Thanks! I've kicked off the full integration tests. Could you just add an example of the error message after your change, to compare against the example in #3306 ? |
|
Hi @princerachit, any update on this? |
|
Will do this weekend @satyamz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3306
Signed-off-by: Prince Rachit Sinha prince.rachit@mayadata.io