Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRI: improve error msg when probe fails #3306

Closed
lilic opened this issue Aug 8, 2018 · 2 comments · Fixed by #3363
Closed

CRI: improve error msg when probe fails #3306

lilic opened this issue Aug 8, 2018 · 2 comments · Fixed by #3363
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality good-first-issue Indicates a good issue for first-time contributors help-wanted An issue that would be good for non-maintainers to attempt k8s Pertains to integration with Kubernetes

Comments

@lilic
Copy link
Contributor

lilic commented Aug 8, 2018

We should format the error msg in a better way to know where it originates. e.g. include CRI probe in the msg.
Currently this is how the error msg looks like:

 probe> ERRO: 2018/08/08 09:50:46.146900 error generating report: rpc error: code = Unavailable desc = grpc: the connection is unavailable
@lilic lilic added k8s Pertains to integration with Kubernetes chore Related to fix/refinement/improvement of end user or new/existing developer functionality help-wanted An issue that would be good for non-maintainers to attempt good-first-issue Indicates a good issue for first-time contributors labels Aug 8, 2018
@bboreham
Copy link
Collaborator

bboreham commented Aug 8, 2018

Do you know where in the code the error originates?

@princerachit
Copy link
Contributor

May I work on this issue? @lilic

princerachit pushed a commit to princerachit/scope that referenced this issue Sep 30, 2018
[3306] refactor(logs): Add reporter name to error logs.
ad1446d 
fixes weaveworks#3306

Capitalize first letter of error log.

Signed-off-by: Prince Rachit Sinha <prince.rachit@mayadata.io>
princerachit pushed a commit to princerachit/scope that referenced this issue Sep 30, 2018
refactor(logs): Add reporter name to error logs.
a097b7a 
1. Adding reporter name to logs improves tracing of error.
2. Capitalize first letter of error log.

Fixes weaveworks#3306

Signed-off-by: Prince Rachit Sinha <prince.rachit@mayadata.io>
This was referenced Sep 30, 2018
Closed
Merged
satyamz pushed a commit to mayadata-io/scope that referenced this issue Aug 8, 2019
@qiell @satyamz
Rebase mdap-rc1 with upstream updates (#170)
94bbc66 
* refactor(logs): Add reporter name to error logs.

1. Adding reporter name to logs improves tracing of error.
2. Capitalize first letter of error log.

Fixes weaveworks#3306

Signed-off-by: Prince Rachit Sinha <prince.rachit@mayadata.io>

* fix: handle errors reported by the conntrack package

In particular, ENOBUFS which indicates data has been dropped.
With this change the collector will restart, thus resynchronising with
the OS.

* fix: remove unused metric SpyDuration

The call to register this metric was removed in weaveworks#633 over three years ago.
If it isn't registered then nobody can see the values.
The measurement is duplicated by metrics added in weaveworks#658.

* Defer metrics registration until we need it

This avoids app-specific metrics appearing in the probe.

* docs: Release 1.11.3

* docs: remove mention of long-deprecated boot2docker

* docs: help users to avoid opening their computer to the Internet

* bump_license

* fix(probe): Update tcptracer-bpf package to cure out-of-order events

Avoid ebpf events out of order by adding offset to time.

* Add another warning about exposing on the Internet

* Remove quay.io from release script

* Bold the warning about exposing on the Internet

* Release 1.11.4

* Update with latest changes

* Add OpenEBS CRs clientset

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add SP and Disk Support

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add new sub-topology under Hosts

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update circle-ci from 1.0 to 2.0

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Fix unit tests in render and kubernetes

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update circle-ci config.yaml to install dependencies

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* update circle-ci for image-tag. (#118)

Signed-off-by: Pradeep <pradeepkumar.bk96@gmail.com>

* Add cStor support in Scope

* Add support for CV, CVR & CSP in Scope

* Add proper shapes for CV, CVR & CSP

* Add status field to CV, CVR & CSP

* Remove unnecessary filter in the APITopologyGroup

* Remove unsed PodComponent method

* Filter disk when Show Pods in Volumes

Signed-off-by: Satyam Zode <satyamzode@gmail.com>

* Fix snapshot filter for show customer resources

Signed-off-by: Satyam Zode <satyamzode@gmail.com>

* Add node tag and status support

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add unknown state if status is empty (#123)

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add adjacency for the CSP, Disk & SPC

* Add adjacency for the CSP, Disk & SPC

* Fix comments for renderer

Signed-off-by: Satyam Zode <satyamzode@gmail.com>

* Change favicon.ico and title (#129)

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add adjacency between volumeSnapshot and clonedPVC (#132)

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Read status only once

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Fix UI balnkout issue

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add disk status and creation time in Disk Node

This will also enable the NodeTag for Disk objects.

Signed-off-by: Satyam Zode <satyamzode@gmail.com>

* Add more details to cv volume (#137)

Signed-off-by: Satyam Zode <satyamzode@gmail.com>

* Update clientset for disk CR

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add new metadata in disk

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update logic to add adjacency between pod and pvc (#141)

- Adjacency was made just by checking the name of pod claim name
and pvc name, issue is when two pvc in different namespace has same
name.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Remove repititive columns (#144)

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Change log level from warn to debug (#147)

Signed-off-by: Satyam Zode <satyamzode@gmail.com>

* Remove checkpoint to preserve system info of users (#149) (#150)

Signed-off-by: Satyam Zode <satyamzode@gmail.com>

* Allow filtering controls on basis of user kind (#153)

* Add support to disable admin controls

This commit will categorize the controls into two types:-
1. Admin Controls (exec, scaleup, scaledown etc.)
2. Read only Controls (logs, describe, attach)

This will add a new flag i.e disableAdminControls
by default, teh value for the above flag will be false,
if value is true, all the admin controls will be disabled.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Read user kind header and filter the controls

This commit will read the header "x-api-user-kind" from request
and check if it is "readAdmin" or not.
If it is the readAdmin, then it will filter all the adminControls
else it will provide all the controls.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Fix table view

* fixed the table view for larger table headers and sidebar issue

* fixes the table header when scrolled

*  Add Block Device support (#162)

* Update openebs clientset to include block device

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update CSP spec to incorporate changes from 0.9 and 1.0

- In 0.9, CSP spec has DiskList but in 1.0 CSP spec has BlockDeviceGroup
To support both add DiskList and Group in CSP spec and update the
clientset of the same.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add Block Device support

This commit will :-
- Visualize Block Device (shape similar to Disk)
- Add Adjacency between BlockDevice and Disk
- Add Adjacency between CSP and BlockDevice only if CSP has block device
list(1.0) otherwise add the adjacency between CSP and Disk(0.9)

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add describe control on block device

This commit will:-
- Add GetBlockDeviceList method to CSP interface.
- Add CaptureBlockDevice method which will be used to fetch the name and
namespace of selected Block Device.
- Add entry of block device in the switch case.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update webpack and package.json

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update ui-components dependency from openebs to mayadata

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* fixes the table header z-index issues

* Update circle ci config (#165)

* Update package.json to exclude building external client

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update circle ci config yaml

- Builds were failing because of ci cache. Update it to use new files
instead of cached ones.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update pvc size to read from status (#166)

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add spec and clientset of bdc

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add adjacency between pv and bdc

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add support to visualize bdc

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality good-first-issue Indicates a good issue for first-time contributors help-wanted An issue that would be good for non-maintainers to attempt k8s Pertains to integration with Kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(logs): Add reporter name to error logs. princerachit/scope
3 participants
@lilic @bboreham @princerachit