Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase mdap-rc1 with upstream updates #170

Merged
merged 56 commits into from
Aug 8, 2019
Merged

Rebase mdap-rc1 with upstream updates #170

merged 56 commits into from
Aug 8, 2019

Conversation

qiell
Copy link

@qiell qiell commented Aug 7, 2019

No description provided.

Prince Rachit Sinha and others added 30 commits September 30, 2018 11:29
1. Adding reporter name to logs improves tracing of error.
2. Capitalize first letter of error log.

Fixes weaveworks#3306

Signed-off-by: Prince Rachit Sinha <prince.rachit@mayadata.io>
In particular, ENOBUFS which indicates data has been dropped.
With this change the collector will restart, thus resynchronising with
the OS.
…rror

fix: handle errors reported by the conntrack package
The call to register this metric was removed in weaveworks#633 over three years ago.
If it isn't registered then nobody can see the values.
The measurement is duplicated by metrics added in weaveworks#658.
This avoids app-specific metrics appearing in the probe.
…stration

Defer metrics registration until we need it
Avoid ebpf events out of order by adding offset to time.
fix(probe): Avoid ebpf events out of order by adding offset to time
refactor(logs): Add reporter name to error logs.
Docs: improve the warning about opening Scope to the Internet
* Add OpenEBS CRs clientset

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add SP and Disk Support

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add new sub-topology under Hosts

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update circle-ci from 1.0 to 2.0

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Fix unit tests in render and kubernetes

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update circle-ci config.yaml to install dependencies

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Pradeep <pradeepkumar.bk96@gmail.com>
* Add support for CV, CVR & CSP in Scope

* Add proper shapes for CV, CVR & CSP

* Add status field to CV, CVR & CSP

* Remove unnecessary filter in the APITopologyGroup

* Remove unsed PodComponent method

* Filter disk when Show Pods in Volumes

Signed-off-by: Satyam Zode <satyamzode@gmail.com>
Signed-off-by: Satyam Zode <satyamzode@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
* Add adjacency for the CSP, Disk & SPC

* Fix comments for renderer

Signed-off-by: Satyam Zode <satyamzode@gmail.com>
satyamz and others added 21 commits August 7, 2019 12:46
This will also enable the NodeTag for Disk objects.

Signed-off-by: Satyam Zode <satyamzode@gmail.com>
Signed-off-by: Satyam Zode <satyamzode@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
- Adjacency was made just by checking the name of pod claim name
and pvc name, issue is when two pvc in different namespace has same
name.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Satyam Zode <satyamzode@gmail.com>
Signed-off-by: Satyam Zode <satyamzode@gmail.com>
* Add support to disable admin controls

This commit will categorize the controls into two types:-
1. Admin Controls (exec, scaleup, scaledown etc.)
2. Read only Controls (logs, describe, attach)

This will add a new flag i.e disableAdminControls
by default, teh value for the above flag will be false,
if value is true, all the admin controls will be disabled.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Read user kind header and filter the controls

This commit will read the header "x-api-user-kind" from request
and check if it is "readAdmin" or not.
If it is the readAdmin, then it will filter all the adminControls
else it will provide all the controls.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
* Update openebs clientset to include block device

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update CSP spec to incorporate changes from 0.9 and 1.0

- In 0.9, CSP spec has DiskList but in 1.0 CSP spec has BlockDeviceGroup
To support both add DiskList and Group in CSP spec and update the
clientset of the same.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add Block Device support

This commit will :-
- Visualize Block Device (shape similar to Disk)
- Add Adjacency between BlockDevice and Disk
- Add Adjacency between CSP and BlockDevice only if CSP has block device
list(1.0) otherwise add the adjacency between CSP and Disk(0.9)

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Add describe control on block device

This commit will:-
- Add GetBlockDeviceList method to CSP interface.
- Add CaptureBlockDevice method which will be used to fetch the name and
namespace of selected Block Device.
- Add entry of block device in the switch case.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
* Update package.json to exclude building external client

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>

* Update circle ci config yaml

- Builds were failing because of ci cache. Update it to use new files
instead of cached ones.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
@coveralls
Copy link

coveralls commented Aug 7, 2019

Pull Request Test Coverage Report for Build 1843

  • 0 of 15 (0.0%) changed or added relevant lines in 6 files are covered.
  • 4318 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.05%) to 26.641%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/multitenant/aws_collector.go 0 2 0.0%
app/multitenant/memcache_client.go 0 2 0.0%
app/multitenant/s3_client.go 0 2 0.0%
app/multitenant/sqs_control_router.go 0 2 0.0%
prog/app.go 0 3 0.0%
probe/probe.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
app/multitenant/consul_client.go 2 52.88%
app/multitenant/sqs_control_router.go 2 0.0%
app/multitenant/consul_pipe_router.go 2 78.39%
app/multitenant/s3_client.go 2 0.0%
prog/app.go 3 0.0%
app/multitenant/memcache_client.go 4 0.0%
app/multitenant/aws_collector.go 10 0.0%
render/detailed/detailed.codecgen.go 1622 28.93%
report/report.codecgen.go 2671 34.9%
Totals Coverage Status
Change from base Build 1807: -0.05%
Covered Lines: 14845
Relevant Lines: 55722

💛 - Coveralls

@qiell qiell self-assigned this Aug 7, 2019
@qiell qiell requested review from avishnu and satyamz August 7, 2019 07:49
Copy link

@satyamz satyamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@satyamz satyamz merged commit 94bbc66 into mdap-rc1 Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants