forked from weaveworks/scope
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase mdap-rc1 with upstream updates #170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Adding reporter name to logs improves tracing of error. 2. Capitalize first letter of error log. Fixes weaveworks#3306 Signed-off-by: Prince Rachit Sinha <prince.rachit@mayadata.io>
In particular, ENOBUFS which indicates data has been dropped. With this change the collector will restart, thus resynchronising with the OS.
…rror fix: handle errors reported by the conntrack package
The call to register this metric was removed in weaveworks#633 over three years ago. If it isn't registered then nobody can see the values. The measurement is duplicated by metrics added in weaveworks#658.
This avoids app-specific metrics appearing in the probe.
Release 1.11.3
fix: remove unused metric SpyDuration
…stration Defer metrics registration until we need it
bump_license , supposed to be 2019 ?
Avoid ebpf events out of order by adding offset to time.
fix(probe): Avoid ebpf events out of order by adding offset to time
Remove quay.io from release script
refactor(logs): Add reporter name to error logs.
Docs: improve the warning about opening Scope to the Internet
* Add OpenEBS CRs clientset Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com> * Add SP and Disk Support Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com> * Add new sub-topology under Hosts Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com> * Update circle-ci from 1.0 to 2.0 Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com> * Fix unit tests in render and kubernetes Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com> * Update circle-ci config.yaml to install dependencies Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Pradeep <pradeepkumar.bk96@gmail.com>
* Add support for CV, CVR & CSP in Scope * Add proper shapes for CV, CVR & CSP * Add status field to CV, CVR & CSP * Remove unnecessary filter in the APITopologyGroup * Remove unsed PodComponent method * Filter disk when Show Pods in Volumes Signed-off-by: Satyam Zode <satyamzode@gmail.com>
Signed-off-by: Satyam Zode <satyamzode@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
* Add adjacency for the CSP, Disk & SPC * Fix comments for renderer Signed-off-by: Satyam Zode <satyamzode@gmail.com>
This will also enable the NodeTag for Disk objects. Signed-off-by: Satyam Zode <satyamzode@gmail.com>
Signed-off-by: Satyam Zode <satyamzode@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
- Adjacency was made just by checking the name of pod claim name and pvc name, issue is when two pvc in different namespace has same name. Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Satyam Zode <satyamzode@gmail.com>
* Add support to disable admin controls This commit will categorize the controls into two types:- 1. Admin Controls (exec, scaleup, scaledown etc.) 2. Read only Controls (logs, describe, attach) This will add a new flag i.e disableAdminControls by default, teh value for the above flag will be false, if value is true, all the admin controls will be disabled. Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com> * Read user kind header and filter the controls This commit will read the header "x-api-user-kind" from request and check if it is "readAdmin" or not. If it is the readAdmin, then it will filter all the adminControls else it will provide all the controls. Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
* Update openebs clientset to include block device Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com> * Update CSP spec to incorporate changes from 0.9 and 1.0 - In 0.9, CSP spec has DiskList but in 1.0 CSP spec has BlockDeviceGroup To support both add DiskList and Group in CSP spec and update the clientset of the same. Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com> * Add Block Device support This commit will :- - Visualize Block Device (shape similar to Disk) - Add Adjacency between BlockDevice and Disk - Add Adjacency between CSP and BlockDevice only if CSP has block device list(1.0) otherwise add the adjacency between CSP and Disk(0.9) Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com> * Add describe control on block device This commit will:- - Add GetBlockDeviceList method to CSP interface. - Add CaptureBlockDevice method which will be used to fetch the name and namespace of selected Block Device. - Add entry of block device in the switch case. Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
* Update package.json to exclude building external client Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com> * Update circle ci config yaml - Builds were failing because of ci cache. Update it to use new files instead of cached ones. Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
Pull Request Test Coverage Report for Build 1843
💛 - Coveralls |
satyamz
approved these changes
Aug 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
avishnu
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.