Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "No Dependencies" message with links to flux docs #4099

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

joshri
Copy link
Contributor

@joshri joshri commented Oct 24, 2023

Closes #3379

image

@joshri joshri added the area/ui Issues that require front-end work label Oct 24, 2023
Copy link
Contributor

@TheGostKasper TheGostKasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -90,28 +72,38 @@ function DependenciesView({ className, automation }: DependenciesViewProps) {
) : (
<Flex className={className} wide tall column align>
<Spacer padding="xl" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Spacer ../> , can be replaced by flex gap ?

href="https://fluxcd.io/flux/components/kustomize/kustomizations/#dependencies"
>
Kustomization
</Link>{" "}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{" "} Is this related to format files?

@joshri joshri merged commit fc4bfe6 into main Oct 25, 2023
17 checks passed
@joshri joshri deleted the 3379-dependencies-msg branch October 25, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Issues that require front-end work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

From the UI, point me to info about the dependsOn field
2 participants