Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "No Dependencies" message with links to flux docs #4099

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Update "No Dependencies" message with links to flux docs #4099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 31 additions & 39 deletions ui/components/DependenciesView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,30 +6,12 @@ import { getGraphNodes } from "../lib/dependencies";
import { Automation, FluxObjectNode, FluxObjectNodesMap } from "../lib/objects";
import DagGraph from "./DagGraph";
import Flex from "./Flex";
import Link from "./Link";
import MessageBox from "./MessageBox";
import RequestStateHandler from "./RequestStateHandler";
import Spacer from "./Spacer";
import Text from "./Text";

const NoDependenciesMessage = styled(MessageBox)`
& {
h2 {
margin-top: 0;
margin-bottom: 0;
}

p {
margin-top: 0;
margin-bottom: 0;
font-size: 16px;
line-height: 20px;
}
}
`;

const Heading = Text.withComponent("h2");
const Paragraph = Text.withComponent("p");

type DependenciesViewProps = {
className?: string;
automation?: Automation;
Expand Down Expand Up @@ -90,28 +72,38 @@ function DependenciesView({ className, automation }: DependenciesViewProps) {
) : (
<Flex className={className} wide tall column align>
<Spacer padding="xl" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Spacer ../> , can be replaced by flex gap ?

<NoDependenciesMessage>
<Heading semiBold size="large">
<MessageBox gap="12">
<Text semiBold size="large">
No Dependencies
</Heading>
<Spacer padding="xs" />
<Paragraph>
There are no dependencies set up for your kustomizations or helm
releases at this time. You can set them up using the dependsOn
field on the kustomization or helm release object.
</Paragraph>
<Spacer padding="xs" />
<Heading semiBold size="large">
</Text>
<Text>
Currently no dependencies are set up for your Kustomizations or
HelmReleases. You can set them up using the dependsOn field on the{" "}
<Link
newTab
href="https://fluxcd.io/flux/components/kustomize/kustomizations/#dependencies"
>
Kustomization
</Link>{" "}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{" "} Is this related to format files?

or{" "}
<Link
newTab
href="https://fluxcd.io/flux/components/helm/helmreleases/#helmrelease-dependencies"
>
Helm Release
</Link>{" "}
object.
</Text>
<Text semiBold size="large">
What are dependencies for?
</Heading>
<Spacer padding="xs" />
<Paragraph>
Dependencies allow you to relate different kustomizations and helm
releases, as well as specifying an order in which your resources
should be started. For example, you can wait for a database to
report as 'Ready' before attempting to deploy other services.
</Paragraph>
</NoDependenciesMessage>
</Text>
<Text>
Dependencies allow you to relate different Kustomizations and Helm
Releases and to specify an order in which your resources should be
started. For example, you can wait for a database to report as
'Ready' before attempting to deploy other services.
</Text>
</MessageBox>
<Spacer padding="xl" />
</Flex>
)}
Expand Down
Loading