-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add EntryChunkPlugin to handle shebang and shims #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fi3ework
force-pushed
the
shebang
branch
4 times, most recently
from
November 11, 2024 18:00
3284409
to
d5971e8
Compare
CodSpeed Performance ReportMerging #399 will not alter performanceComparing Summary
|
fi3ework
force-pushed
the
shebang
branch
6 times, most recently
from
November 13, 2024 09:56
021b27f
to
db310bd
Compare
fi3ework
force-pushed
the
shebang
branch
7 times, most recently
from
November 14, 2024 04:55
a6ddd4d
to
fc198ad
Compare
fi3ework
force-pushed
the
shebang
branch
3 times, most recently
from
November 14, 2024 05:52
3f6e249
to
10633d7
Compare
Timeless0911
approved these changes
Nov 15, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #391.
Fix #381.
Fix #166.
Fix #425.
Overview
import.meta.url
. Previously, we can't use BannerPlugin to insert it into the top of the bundle as there might be a existing"use strict"
, inject to the end also does not help as there will be a TDZ. In thi PR, usingprocessAssets
hook to insert the shim code to the correct position while preserve the leading"use strict"
.Related Links
Checklist