test: multiple entries now do not affect each other #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #485 will not alter performanceComparing Summary
|
Timeless0911
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Finish the test of multiple entry, resolved by #399.
#399 fixed #316.
#399 fixed #452.
Why it fixed
In #399, each entry is appended with a
?__rslib_entry__query so importingfoofromindexwill be distinguished as a different module from the entry module. Which will preventfoofrom concatenation bailout.FYI:
layercould also distinguish the entry module, we might, could uselayerif one day entry query is removed.It's not done.
Currently, chunk splitting of shared modules is not yet supported, but at least it works for now. We will track the progress of chunk splitting in a dedicated issue.
Related Links
Checklist