Skip to content

Commit

Permalink
Update two SVG tests to be consistent between browsers (#23240)
Browse files Browse the repository at this point in the history
svg/import/pservers-grad-08-b-manual.svg:
This test renders some text using a font that doesn't contain the space glyph.
However, the content contains the space character, and doesn't specify a fallback
font. This means that different browsers on the same OS will pick different
fallback fonts, causing different renderings. Instead, the test should be updated
to specify a fallback font, which makes browsers render it consistently.

imported/w3c/web-platform-tests/svg/import/text-altglyph-01-b-manual.svg:
Similarly, this test renders text with a font that doesn't support those characters.
(It does it using <altGlyph>, but support for <altGlyph> has been removed in SVG 2.0
and neither Safari nor Firefox support it.) A fallback font should be supplied to the
test to get consistent renderings across browsers.

Co-authored-by: Myles C. Maxfield <mmaxfield@apple.com>
  • Loading branch information
litherum and litherum authored Apr 25, 2020
1 parent 7e77515 commit 51151cf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions svg/import/pservers-grad-08-b-manual.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion svg/import/text-altglyph-01-b-manual.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 51151cf

Please sign in to comment.