Update two SVG tests to be consistent between browsers #23240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AmeliaBR,
boggydigital,
dirkschulze,
ewilligers,
fsoder,
nikosandronikos and
shallawa
fsoder
approved these changes
Apr 24, 2020
|
To my (untrained) eye, the failing check looks unrelated. |
svg/import/pservers-grad-08-b-manual.svg: This test renders some text using a font that doesn't contain the space glyph. However, the content contains the space character, and doesn't specify a fallback font. This means that different browsers on the same OS will pick different fallback fonts, causing different renderings. Instead, the test should be updated to specify a fallback font, which makes browsers render it consistently. imported/w3c/web-platform-tests/svg/import/text-altglyph-01-b-manual.svg: Similarly, this test renders text with a font that doesn't support those characters. (It does it using <altGlyph>, but support for <altGlyph> has been removed in SVG 2.0 and neither Safari nor Firefox support it.) A fallback font should be supplied to the test to get consistent renderings across browsers.
litherum
changed the title
|
Yes, that looks like it may be what's discussed in #21529 . I'll try a close-reopen cycle to see if that helps... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
svg/import/pservers-grad-08-b-manual.svg:This test renders some text using a font that doesn't contain the space glyph.
However, the content contains the space character, and doesn't specify a fallback
font. This means that different browsers on the same OS will pick different
fallback fonts, causing different renderings. Instead, the test should be updated
to specify a fallback font, which makes browsers render it consistently.
svg/import/text-altglyph-01-b-manual.svg:Similarly, this test renders text with a font that doesn't support those characters.
(It does it using , but support for has been removed in SVG 2.0
and neither Safari nor Firefox support it.) A fallback font should be supplied to the
test to get consistent renderings across browsers.