Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tests for the legacy aliases of the compat spec #34493

Closed
58 tasks done
karlcow opened this issue Jun 20, 2022 · 5 comments
Closed
58 tasks done

Missing tests for the legacy aliases of the compat spec #34493

karlcow opened this issue Jun 20, 2022 · 5 comments

Comments

@karlcow
Copy link
Contributor

karlcow commented Jun 20, 2022

The compat spec has a section called legacy name aliases. These are the properties which are necessary to support for a browser to be able to work with the Web.

  • Do we have tests for each of these aliases?
  • Should they be in their own compat section? Or in each thematic individual section?
  • -webkit-align-items align-items
  • -webkit-align-content align-content
  • -webkit-align-self align-self
  • -webkit-animation-name animation-name
  • -webkit-animation-duration animation-duration
  • -webkit-animation-timing-function animation-timing-function
  • -webkit-animation-iteration-count animation-iteration-count
  • -webkit-animation-direction animation-direction
  • -webkit-animation-play-state animation-play-state
  • -webkit-animation-delay animation-delay
  • -webkit-animation-fill-mode animation-fill-mode
  • -webkit-animation animation
  • -webkit-backface-visibility backface-visibility
  • -webkit-background-clip background-clip
  • -webkit-background-origin background-origin
  • -webkit-border-bottom-left-radius border-bottom-left-radius
  • -webkit-border-bottom-right-radius border-bottom-right-radius
  • -webkit-border-top-left-radius border-top-left-radius
  • -webkit-border-top-right-radius border-top-right-radius
  • -webkit-border-radius border-radius
  • -webkit-box-shadow box-shadow
  • -webkit-box-sizing box-sizing
  • -webkit-flex flex
  • -webkit-flex-basis flex-basis
  • -webkit-flex-direction flex-direction
  • -webkit-flex-flow flex-flow
  • -webkit-flex-grow flex-grow
  • -webkit-flex-shrink flex-shrink
  • -webkit-flex-wrap flex-wrap
  • -webkit-filter filter
  • -webkit-justify-content justify-content
  • -webkit-mask mask
  • -webkit-mask-box-image mask-border
  • -webkit-mask-box-image-outset mask-border-outset
  • -webkit-mask-box-image-repeat mask-border-repeat
  • -webkit-mask-box-image-slice mask-border-slice
  • -webkit-mask-box-image-source mask-border-source
  • -webkit-mask-box-image-width mask-border-width
  • -webkit-mask-clip mask-clip
  • -webkit-mask-composite mask-composite
  • -webkit-mask-image mask-image
  • -webkit-mask-origin mask-origin
  • -webkit-mask-position mask-position
  • -webkit-mask-repeat mask-repeat
  • -webkit-mask-size mask-size
  • -webkit-order order
  • -webkit-perspective perspective
  • -webkit-perspective-origin perspective-origin
  • -webkit-transform-origin transform-origin
  • -webkit-transform-style transform-style
  • -webkit-transform transform
  • -webkit-transition-delay transition-delay
  • -webkit-transition-duration transition-duration
  • -webkit-transition-property transition-property
  • -webkit-transition-timing-function transition-timing-function
  • -webkit-transition transition
@karlcow
Copy link
Contributor Author

karlcow commented Jun 20, 2022

For example, in CSS background, I do not see anything related to -webkit-

@karlcow
Copy link
Contributor Author

karlcow commented Jun 22, 2022

The second question is answered with https://github.com/web-platform-tests/wpt/tree/master/compat

@karlcow
Copy link
Contributor Author

karlcow commented Jun 22, 2022

Let's check what is missing.

Checking the correlation between the spec and the tests in https://github.com/web-platform-tests/wpt/blob/master/compat/css-style-declaration-alias-enumeration.html

This tests only that the webkit property exists… but not necessary that the right equivalent is associated with.

Property Spec Test Comment
WebKitBackgroundSize ❗️ Issue #28
WebKitBackgroundClip _ Need to add test for this but taking into account that Chrome is not yet implementing text value without prefix. So we need to surface it.
WebKitBoxSizing _ has been forgotten in the tests?

The tests in

'webkitMaskBoxImage',
'webkitMaskBoxImageOutset',
'webkitMaskBoxImageRepeat',
'webkitMaskBoxImageSlice',
'webkitMaskBoxImageSource',
'webkitMaskBoxImageWidth',

are indeed enumerated but the alias name is different. It would be probably be good to double check if the right property is modified.

@karlcow
Copy link
Contributor Author

karlcow commented Jun 22, 2022

why webKitMaskBoxImage is listed in

'webkitMaskBoxImage',
'webkitMaskBoxImageOutset',
'webkitMaskBoxImageRepeat',
'webkitMaskBoxImageSlice',
'webkitMaskBoxImageSource',
'webkitMaskBoxImageWidth',

while https://compat.spec.whatwg.org/#css-simple-aliases gives for aliases mask-border-* which is not implemented at all from my preliminary tests.

Probably should open an issue on compat spec.
The addition was done in 2016

but 6+ years later, there is still no browser implementing mask-border or maybe experimental modes?
https://caniuse.com/mdn-css_properties_mask-border

hmmm no.
I''ll open a new issue.

@karlcow karlcow changed the title What are the missing tests for the legacy aliases of the compat spec Missing tests for the legacy aliases of the compat spec Jun 22, 2022
karlcow added a commit to karlcow/wpt that referenced this issue Jun 22, 2022
karlcow added a commit to karlcow/wpt that referenced this issue Jun 22, 2022
@karlcow
Copy link
Contributor Author

karlcow commented Jun 22, 2022

-webkit-box-sizing was added to the spec by @miketaylr in 2015.
whatwg/compat#9

but no test exists for it on the alias enumeration.
We could add one and I check, this is supported everywhere with both -webkit-box-sizing and box-sizing

karlcow added a commit to karlcow/wpt that referenced this issue Jun 22, 2022
…alias

It is correctly defines in browsers and everyone implements it.
This was defined initially in
whatwg/compat#9
karlcow added a commit to karlcow/wpt that referenced this issue Jun 23, 2022
… of alias

As shown in whatwg/compat#202
there is currently no browsers implementing the mask-border-*,
which should be the equivalent.

They stand on their own and probably for now deserves a test
by themselves.
karlcow added a commit to karlcow/wpt that referenced this issue Jun 23, 2022
As shown in whatwg/compat#202
there is currently no browsers implementing the mask-border-*,
which should be the equivalent.

They stand on their own and probably for now deserves a test
by themselves.
@web-platform-tests web-platform-tests deleted a comment Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant