-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec -webkit-mask-* #14
Comments
You can find this data at https://www.chromestatus.com/metrics/css/popularity However, if these are being used by Google search, then that'll dominate the usage so we'll have no idea how risky it would be to remove until Google search stops using it. Not sure who the best contact for this in Blink would be. I guess it's style+paint? @dirkschulze @RByers, do you know? |
Thanks @foolip |
As of today
|
We aliased a handful (all?) of the CSS mask props to -webkit-mask props here: https://bugzilla.mozilla.org/show_bug.cgi?id=1242617 See http://hg.mozilla.org/mozilla-central/rev/f6eba571ce59 for actual mappings. TODO:
@karlcow do you know offhand of any sites that use these props we can test against? (I can probably find some easily if you don't) |
Gonna pile some demos from quick googling here. To investigate failures.
https://github.com/WebKit/webkit/tree/master/LayoutTests/fast/masking |
Going to update the title, because this is something we feel important enough to support in Gecko. |
Here's a naive guess at how mapping should happen (I think a few things were left out of the commit at http://hg.mozilla.org/mozilla-central/rev/f6eba571ce59):
Stuff with ❓ is just a guess, based on naming similarities and descriptions. Need to look more closely. TODO: Look at props that take keywords and see if values between the two are the same. |
@miketaylr Well I was about to suggest images.google.com as the biggest offender… but testing it this morning I was… in shock! They fixed it: https://bugzilla.mozilla.org/show_bug.cgi?id=921532#c17 for Chrome and use SVG. |
Cool! OK, I'll keep testing demos then and find other sites in my bugmail. |
A few notes from research. Safari originally shipped a
Will have to keep an eye on |
I'll double check the |
I should probably remove (Let's keep an eye out for web content that depends on this, but I suspect it would be very, very low). |
158 code results. |
Yep, most of those just forks of WebKit tests. |
This was never implemented in Blink (it was added to WebKit after the Blink/WebKit split). Assuming that Chrome doesn't need it for compat, probably nobody else does. It can be readded if needed in the future.
Based on https://developer.apple.com/library/safari/documentation/InternetWeb/Conceptual/SafariVisualEffectsProgGuide/Masks/Masks.html, https://github.com/WebKit/webkit/blob/master/Source/WebCore/css/CSSPropertyNames.in#L548, and stuff like http://www.html5rocks.com/en/tutorials/masking/adobe/#toc-the-mask-border-property I'm fairly confident the main difference between Comparing between https://www.w3.org/TR/2013/WD-css-masking-20130620/#box-image-masks and |
6 years later no browsers are implementing |
Again just here for getting a better understanding of how widespread is it.
Currently the tier1 version of google search is using
-webkit-mask-image
and-webkit-mask-size
. See https://bugzilla.mozilla.org/show_bug.cgi?id=921532 To note that Google is serving an inferior version to Firefox and IE where they get links at the bottom instead of infinite loading and CSS sprites instead of the mask.About CSS Masks usage http://caniuse.com/#feat=css-masks
The support is not overlapping. aka Webkit/Blink family supports only -webkit-mask-image, etc.
And Gecko supports only SVG masks.
And Trident/Edge doesn't support anything.
We have a case of non overlapping feature.
@foolip I wonder if there are data on how widespread the usage is on the Web for Chrome?
The text was updated successfully, but these errors were encountered: