Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom-elements: Add a test for upgrade failure due to non-null shado… #17162

Merged
merged 4 commits into from
Jun 11, 2019
Merged

custom-elements: Add a test for upgrade failure due to non-null shado… #17162

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81c995d
custom-elements: Add a test for upgrade failure due to non-null shado…
tkent-google Jun 4, 2019
2407352
Add internals test too.
tkent-google Jun 5, 2019
66b7c2a
Removed an invalid test.
tkent-google Jun 5, 2019
0b2322f
Check DOMException type by an error event handler
tkent-google Jun 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions custom-elements/upgrading.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
<body>
<div id="log"></div>
<script>
setup({allow_uncaught_exception:true});

class PredefinedCustomElement extends HTMLElement {}
customElements.define('predefined-custom-element', PredefinedCustomElement);
Expand Down Expand Up @@ -185,6 +186,23 @@

});

test(() => {
class ShadowDisabledElement extends HTMLElement {
static get disabledFeatures() { return ['shadow']; }
}
let error = null;
window.addEventListener('error', e => { error = e.error; }, {once: true});
let element = document.createElement('shadow-disabled');
element.attachShadow({mode: 'open'});
customElements.define('shadow-disabled', ShadowDisabledElement);
customElements.upgrade(element);
assert_false(element instanceof ShadowDisabledElement,
'Upgrading should fail.');
assert_true(error instanceof DOMException);
assert_equals(error.name, 'NotSupportedError');
}, 'If definition\'s disable shadow is true and element\'s shadow root is ' +
'non-null, then throw a "NotSupportedError" DOMException.');

</script>
</body>
</html>