-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom-elements: Add a test for upgrade failure due to non-null shado… #17162
Conversation
…w root and disabledFeatures Specification PR: whatwg/html#4673
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think It'd be ideal if we also caught the NotSupportedError using window.onerror, though maybe that's too involved with WPT?
That's a good idea. Done. |
In particular if folks disable support for ShadowRoot and ElementInternals, this will make upgrade an element throw a NotSupportedError so element constructors only run with expected state. Tests: web-platform-tests/wpt#17162.
…w root and disabledFeatures
Specification PR: whatwg/html#4673