Make upgrade an element throw more #4673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular if folks disable support for ShadowRoot and ElementInternals, this will make upgrade an element throw a NotSupportedError so element constructors only run with expected state.
annevk
added
the
topic: custom elements
tkent-google
approved these changes
Jun 4, 2019
domenic
approved these changes
Jun 4, 2019
tkent-google
reviewed
Jun 4, 2019
tkent-google
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 4, 2019
…w root and disabledFeatures Specification PR: whatwg/html#4673
|
Test PR: web-platform-tests/wpt#17162 |
|
Thanks for the review, so |
EdgarChen
approved these changes
Jun 7, 2019
annevk
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 11, 2019
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 13, 2019
…ding Specification PR: whatwg/html#4673 Bug: 972951 Change-Id: I9e3db95eb15e2e40d9e3412e97873f795cc7b028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657521 Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#668768}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 19, 2019
…failure due to non-null shado…, a=testonly Automatic update from web-platform-tests HTML: test upgrade custom element failure due to disabledFeatures Specification PR: whatwg/html#4673. -- wp5At-commits: a3dcc65d854e242e61aeb1c68c26742cd278ea9a wpt-pr: 17162
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jun 19, 2019
…failure due to non-null shado…, a=testonly Automatic update from web-platform-tests HTML: test upgrade custom element failure due to disabledFeatures Specification PR: whatwg/html#4673. -- wp5At-commits: a3dcc65d854e242e61aeb1c68c26742cd278ea9a wpt-pr: 17162
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2019
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…failure due to non-null shado…, a=testonly Automatic update from web-platform-tests HTML: test upgrade custom element failure due to disabledFeatures Specification PR: whatwg/html#4673. -- wp5At-commits: a3dcc65d854e242e61aeb1c68c26742cd278ea9a wpt-pr: 17162 UltraBlame original commit: d029a500f958bb1754e910cabdb554615bd43064
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…failure due to non-null shado…, a=testonly Automatic update from web-platform-tests HTML: test upgrade custom element failure due to disabledFeatures Specification PR: whatwg/html#4673. -- wp5At-commits: a3dcc65d854e242e61aeb1c68c26742cd278ea9a wpt-pr: 17162 UltraBlame original commit: d029a500f958bb1754e910cabdb554615bd43064
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…failure due to non-null shado…, a=testonly Automatic update from web-platform-tests HTML: test upgrade custom element failure due to disabledFeatures Specification PR: whatwg/html#4673. -- wp5At-commits: a3dcc65d854e242e61aeb1c68c26742cd278ea9a wpt-pr: 17162 UltraBlame original commit: d029a500f958bb1754e910cabdb554615bd43064
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular if folks disable support for ShadowRoot and ElementInternals, this will make upgrade an element throw a NotSupportedError so element constructors only run with expected state.
(See WHATWG Working Mode: Changes for more details.)
/custom-elements.html ( diff )
/infrastructure.html ( diff )