DOM: latest DocumentFragment adoption changes #22504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See whatwg/dom#819. Verified with jsdom/jsdom#2925.
wpt-pr-bot
requested review from
domenic,
hayatoito,
jdm,
kojiishi,
rniwa,
snuggs,
TakayoshiKochi and
zqzhang
annevk
added a commit
to whatwg/html
that referenced
this pull request
Mar 28, 2020
3 tasks
|
The additional scenario can only be hit with shadow trees I think, so I think the one additional test is sufficient here. |
annevk
added a commit
to whatwg/dom
that referenced
this pull request
Oct 18, 2022
Tests: web-platform-tests/wpt#22504. Corresponding HTML PR: whatwg/html#5413. Closes #813 and closes #814.
annevk
added a commit
to whatwg/html
that referenced
this pull request
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/dom#819.
Verified with jsdom/jsdom#2925.
I should probably add other tests to dom/nodes/adoption.window.js though to cover a host whose DF contains another host and variants on that as no test in web-platform-tests caught my accidental logic bug.