Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to test replace before load #28480

Merged
merged 18 commits into from
Jun 24, 2021
Merged

Attempt to test replace before load #28480

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c1787b6
Attempt to test replace before load
domenic Apr 14, 2021
75314f6
Add history.length checks and test a-click/form-submit
domenic Apr 14, 2021
de13831
Add pushState() test
domenic Apr 14, 2021
a1923b9
Test during load; figured out a way to stop HTML escaping
domenic Apr 14, 2021
ed10f75
Remove slow image to try to avoid timeouts
domenic Apr 15, 2021
97fc6b0
Flip a couple pass conditions
domenic Apr 15, 2021
31dccb1
Test user clicks on <a>s
domenic May 21, 2021
d4f8cca
Test location setter + user clicks
domenic May 24, 2021
700daf1
Test location.assign() from user clicks and setting iframe src.
domenic May 24, 2021
fc76679
Test other ways of submitting the form
domenic May 24, 2021
40b6bc6
Fix form submit tests
domenic May 24, 2021
2a2c4b5
Flip window open tests and add popup ones
domenic May 24, 2021
9804904
Mark these older tests as non-tentative
domenic May 24, 2021
c910c92
Rename better
domenic May 24, 2021
c68352f
Add pageshow variants
domenic Jun 17, 2021
c94493b
Fix tests
domenic Jun 24, 2021
b8c8536
Avoid 1 second timeout
domenic Jun 24, 2021
5247a91
More robust waiting
domenic Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions ...browsing-the-web/navigating-across-documents/replace-before-load/a-click-during-load.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<!DOCTYPE html>
<meta charset="utf-8">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/helpers.js"></script>

<body>
<script>
"use strict";
promise_test(async t => {
const sentinelIframe = await setupSentinelIframe(t);
const startingHistoryLength = history.length;

const code = `
window.onload = () => {
const a = document.createElement("a");
a.href = "/common/blank.html?thereplacement";
document.body.append(a);
a.click();
};
`;

const startURL = "resources/code-injector.html?pipe=sub(none)&code=" + encodeURIComponent(code);
const afterReplacementURL = "/common/blank.html?thereplacement";
const iframe = insertIframe(t, startURL);

assert_equals(history.length, startingHistoryLength, "Inserting the under-test iframe must not change history.length");

await waitForLoadAllowingIntermediateLoads(t, iframe, afterReplacementURL);
assert_equals(history.length, startingHistoryLength + 1, "history.length must change after waiting for the load");
}, "aElement.click() during the load event must NOT replace");
</script>
32 changes: 32 additions & 0 deletions ...sing-the-web/navigating-across-documents/replace-before-load/a-click-during-pageshow.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<!DOCTYPE html>
<meta charset="utf-8">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/helpers.js"></script>

<body>
<script>
"use strict";
promise_test(async t => {
const sentinelIframe = await setupSentinelIframe(t);
const startingHistoryLength = history.length;

const code = `
window.onpageshow = () => {
const a = document.createElement("a");
a.href = "/common/blank.html?thereplacement";
document.body.append(a);
a.click();
};
`;

const startURL = "resources/code-injector.html?pipe=sub(none)&code=" + encodeURIComponent(code);
const afterReplacementURL = "/common/blank.html?thereplacement";
const iframe = insertIframe(t, startURL);

assert_equals(history.length, startingHistoryLength, "Inserting the under-test iframe must not change history.length");

await waitForLoadAllowingIntermediateLoads(t, iframe, afterReplacementURL);
assert_equals(history.length, startingHistoryLength + 1, "history.length must change after waiting for the load");
}, "aElement.click() during the pageshow event must NOT replace");
</script>
30 changes: 30 additions & 0 deletions html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<!DOCTYPE html>
<meta charset="utf-8">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/helpers.js"></script>

<body>
<script>
"use strict";
promise_test(async t => {
const sentinelIframe = await setupSentinelIframe(t);
const startingHistoryLength = history.length;

const code = `
const a = document.createElement("a");
a.href = "/common/blank.html?thereplacement";
document.currentScript.before(a);
a.click();
`;

const startURL = "resources/code-injector.html?pipe=sub(none)&code=" + encodeURIComponent(code);
const afterReplacementURL = "/common/blank.html?thereplacement";
const iframe = insertIframe(t, startURL);

assert_equals(history.length, startingHistoryLength, "Inserting the under-test iframe must not change history.length");

await waitForLoad(t, iframe, afterReplacementURL);
assert_equals(history.length, startingHistoryLength + 1, "history.length must change after waiting for the load");
}, "aElement.click() before the load event must NOT replace");
</script>
36 changes: 36 additions & 0 deletions ...ing-the-web/navigating-across-documents/replace-before-load/a-user-click-during-load.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<!DOCTYPE html>
<meta charset="utf-8">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/helpers.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>

<body>
<script>
"use strict";
promise_test(async t => {
const sentinelIframe = await setupSentinelIframe(t);
const startingHistoryLength = history.length;

const code = `
window.onload = () => {
const a = document.createElement("a");
a.href = "/common/blank.html?thereplacement";
a.id = "the-anchor";
a.textContent = "needs to have content to be clickable";
document.body.append(a);
parent.test_driver.click(a);
};
`;

const startURL = "resources/slow-code-injector.html?pipe=sub(none)&code=" + encodeURIComponent(code);
const afterReplacementURL = "/common/blank.html?thereplacement";
const iframe = insertIframe(t, startURL);

assert_equals(history.length, startingHistoryLength, "Inserting the under-test iframe must not change history.length");

await waitForLoadAllowingIntermediateLoads(t, iframe, afterReplacementURL);
assert_equals(history.length, startingHistoryLength + 1, "history.length must change after waiting for the load");
}, "User click on <a> during the load event must NOT replace");
</script>
36 changes: 36 additions & 0 deletions ...the-web/navigating-across-documents/replace-before-load/a-user-click-during-pageshow.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<!DOCTYPE html>
<meta charset="utf-8">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/helpers.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>

<body>
<script>
"use strict";
promise_test(async t => {
const sentinelIframe = await setupSentinelIframe(t);
const startingHistoryLength = history.length;

const code = `
window.onpageshow = () => {
const a = document.createElement("a");
a.href = "/common/blank.html?thereplacement";
a.id = "the-anchor";
a.textContent = "needs to have content to be clickable";
document.body.append(a);
parent.test_driver.click(a);
};
`;

const startURL = "resources/slow-code-injector.html?pipe=sub(none)&code=" + encodeURIComponent(code);
const afterReplacementURL = "/common/blank.html?thereplacement";
const iframe = insertIframe(t, startURL);

assert_equals(history.length, startingHistoryLength, "Inserting the under-test iframe must not change history.length");

await waitForLoadAllowingIntermediateLoads(t, iframe, afterReplacementURL);
assert_equals(history.length, startingHistoryLength + 1, "history.length must change after waiting for the load");
}, "User click on <a> during the pageshow event must NOT replace");
</script>
34 changes: 34 additions & 0 deletions ...owsers/browsing-the-web/navigating-across-documents/replace-before-load/a-user-click.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<!DOCTYPE html>
<meta charset="utf-8">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/helpers.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>

<body>
<script>
"use strict";
promise_test(async t => {
const sentinelIframe = await setupSentinelIframe(t);
const startingHistoryLength = history.length;

const code = `
const a = document.createElement("a");
a.href = "/common/blank.html?thereplacement";
a.id = "the-anchor";
a.textContent = "needs to have content to be clickable";
document.currentScript.before(a);
parent.test_driver.click(a);
`;

const startURL = "resources/slow-code-injector.html?pipe=sub(none)&code=" + encodeURIComponent(code);
const afterReplacementURL = "/common/blank.html?thereplacement";
const iframe = insertIframe(t, startURL);

assert_equals(history.length, startingHistoryLength, "Inserting the under-test iframe must not change history.length");

await waitForLoad(t, iframe, afterReplacementURL);
assert_equals(history.length, startingHistoryLength + 1, "history.length must change after waiting for the load");
}, "User click on <a> before the load event must NOT replace");
</script>
41 changes: 41 additions & 0 deletions ...e-web/navigating-across-documents/replace-before-load/form-requestsubmit-during-load.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<!DOCTYPE html>
<meta charset="utf-8">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/helpers.js"></script>

<body>
<script>
"use strict";
promise_test(async t => {
const sentinelIframe = await setupSentinelIframe(t);
const startingHistoryLength = history.length;

const code = `
window.onload = () => {
const form = document.createElement("form");
form.action = "/common/blank.html";

const input = document.createElement("input");
input.type = "hidden";
input.name = "thereplacement";
form.append(input);

document.body.append(form);
form.requestSubmit();
};
`;

const startURL = "resources/code-injector.html?pipe=sub(none)&code=" + encodeURIComponent(code);
const afterReplacementURL = "/common/blank.html?thereplacement=";
const iframe = insertIframe(t, startURL);

assert_equals(history.length, startingHistoryLength, "Inserting the under-test iframe must not change history.length");

await waitForLoadAllowingIntermediateLoads(t, iframe, afterReplacementURL);
assert_equals(history.length, startingHistoryLength, "history.length must not change after waiting for the replacement");

await checkSentinelIframe(t, sentinelIframe);
assert_equals(history.length, startingHistoryLength, "history.length must not change after checking the sentinel iframe");
}, "Replace during the load event, triggered by formElement.submit()");
</script>
41 changes: 41 additions & 0 deletions ...b/navigating-across-documents/replace-before-load/form-requestsubmit-during-pageshow.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<!DOCTYPE html>
<meta charset="utf-8">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/helpers.js"></script>

<body>
<script>
"use strict";
promise_test(async t => {
const sentinelIframe = await setupSentinelIframe(t);
const startingHistoryLength = history.length;

const code = `
window.onpageshow = () => {
const form = document.createElement("form");
form.action = "/common/blank.html";

const input = document.createElement("input");
input.type = "hidden";
input.name = "thereplacement";
form.append(input);

document.body.append(form);
form.requestSubmit();
};
`;

const startURL = "resources/code-injector.html?pipe=sub(none)&code=" + encodeURIComponent(code);
const afterReplacementURL = "/common/blank.html?thereplacement=";
const iframe = insertIframe(t, startURL);

assert_equals(history.length, startingHistoryLength, "Inserting the under-test iframe must not change history.length");

await waitForLoadAllowingIntermediateLoads(t, iframe, afterReplacementURL);
assert_equals(history.length, startingHistoryLength, "history.length must not change after waiting for the replacement");

await checkSentinelIframe(t, sentinelIframe);
assert_equals(history.length, startingHistoryLength, "history.length must not change after checking the sentinel iframe");
}, "Replace during the pageshow event, triggered by formElement.submit()");
</script>
39 changes: 39 additions & 0 deletions .../browsing-the-web/navigating-across-documents/replace-before-load/form-requestsubmit.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<!DOCTYPE html>
<meta charset="utf-8">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/helpers.js"></script>

<body>
<script>
"use strict";
promise_test(async t => {
const sentinelIframe = await setupSentinelIframe(t);
const startingHistoryLength = history.length;

const code = `
const form = document.createElement("form");
form.action = "/common/blank.html";

const input = document.createElement("input");
input.type = "hidden";
input.name = "thereplacement";
form.append(input);

document.currentScript.before(form);
form.requestSubmit();
`;

const startURL = "resources/code-injector.html?pipe=sub(none)&code=" + encodeURIComponent(code);
const afterReplacementURL = "/common/blank.html?thereplacement=";
const iframe = insertIframe(t, startURL);

assert_equals(history.length, startingHistoryLength, "Inserting the under-test iframe must not change history.length");

await waitForLoad(t, iframe, afterReplacementURL);
assert_equals(history.length, startingHistoryLength, "history.length must not change after waiting for the replacement");

await checkSentinelIframe(t, sentinelIframe);
assert_equals(history.length, startingHistoryLength, "history.length must not change after checking the sentinel iframe");
}, "Replace before load, triggered by formElement.requestSubmit()");
</script>
45 changes: 45 additions & 0 deletions ...navigating-across-documents/replace-before-load/form-submit-button-click-during-load.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
<!DOCTYPE html>
<meta charset="utf-8">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/helpers.js"></script>

<body>
<script>
"use strict";
promise_test(async t => {
const sentinelIframe = await setupSentinelIframe(t);
const startingHistoryLength = history.length;

const code = `
window.onload = () => {
const form = document.createElement("form");
form.action = "/common/blank.html";
const input = document.createElement("input");
input.type = "hidden";
input.name = "thereplacement";
form.append(input);
const button = document.createElement("button");
button.type = "submit";
form.append(button);
document.body.append(form);
button.click();
};
`;

const startURL = "resources/code-injector.html?pipe=sub(none)&code=" + encodeURIComponent(code);
const afterReplacementURL = "/common/blank.html?thereplacement=";
const iframe = insertIframe(t, startURL);

assert_equals(history.length, startingHistoryLength, "Inserting the under-test iframe must not change history.length");

await waitForLoadAllowingIntermediateLoads(t, iframe, afterReplacementURL);
assert_equals(history.length, startingHistoryLength, "history.length must not change after waiting for the replacement");

await checkSentinelIframe(t, sentinelIframe);
assert_equals(history.length, startingHistoryLength, "history.length must not change after checking the sentinel iframe");
}, "Replace during load, triggered by submitButton.click()");
</script>
Loading