Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPT] BFCache: focus should be kept around BFCache #31084

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Oct 4, 2021

This CL adds a test to confirm that,
when page gets into and out of BFCache,

  • Focus should be kept and
  • blur/focus events are not fired.

The current results are

Safari: Pass
Firefox: Focus remains the same but blur/focus events are fired.
Chrome: Focus is lost.

See whatwg/html#6696
for other status and implementation bug links etc.

Bug: 1107415, 1253728, whatwg/html#5878
Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198456
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#968703}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-3198456 branch 2 times, most recently from b3ca010 to 0d35430 Compare October 13, 2021 22:15
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [WPT] BFCache: focus [WPT] BFCache: focus should be kept around BFCache Oct 19, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-3198456 branch 2 times, most recently from 2d8fc8e to 73deb5c Compare October 25, 2021 08:06
@rakina
Copy link
Contributor

rakina commented Nov 12, 2021

FYI @annevk @smaug---- @cdumez @rniwa @domenic in case people are interested in reviewing this BFCache WPT

This CL adds a test to confirm that,
when page gets into and out of BFCache,

- Focus should be kept and
- blur/focus events are not fired.

The current results are

Safari: Pass
Firefox: Focus remains the same but blur/focus events are fired.
Chrome: Focus is lost.

See whatwg/html#6696
for other status and implementation bug links etc.

Bug: 1107415, 1253728, whatwg/html#5878
Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198456
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#968703}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants