Add notes for focus & non-"fully active" documents #6696

rakina · 2021-05-19T13:23:51Z

Fixes #5878. Clarifies that the focused element stays the same/not reset when a document's "full active" state changed, and no events (focus/blur) are fired, as suggested by @domenic in #5878 (comment).

At least two implementers are interested (and none opposed):
- Chrome
- Firefox
- Safari already implements this
Tests are written and can be reviewed and commented upon at:
- [WPT] BFCache: focus should be kept around BFCache web-platform-tests/wpt#31084
Implementation bugs are filed:
- Chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=1259997
- Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1735828

(See WHATWG Working Mode: Changes for more details.)

/interaction.html ( diff )
/rendering.html ( diff )

Fixes whatwg#5878. Clarifies that the focused element stays the same/not reset when a document's "full active" state changed, and no events (focus/blur) are fired

source

domenic · 2021-05-19T16:37:09Z

source

+  <p class="note">The <span>fully active</span> state does not affect wheter an element is
+  <span>being rendered</span> or not. Even if a document is not <span>fully active</span> and not
+  shown at all to the user, elements within it can still qualify as "being rendered".</p>
+
  <p>An element is said to <dfn>intersect the viewport</dfn> when it is <span>being rendered</span>
  and its associated CSS layout box intersects the <span>viewport</span>.</p>


I wonder what the viewport is for non-fully active documents... probably it stays the same? Otherwise a bunch of IntersectionObservers would fire whenever you enter bfcache.

Ah, interesting. I read https://drafts.csswg.org/css2/#viewport a little bit, it doesn't really say much about the interaction with the document, but I think it should stay the same. Should we add a note here too?

Yeah, I think something here would be good. I was thinking of maybe a note here plus a normative update to CSS2, but CSS2 is so environment-agnostic that maybe it makes sense to put something normative here instead, since HTML kind of "owns" the notion of what a viewport means for web browsers?

OK, added a note, PTAL :)

annevk

Nice!

source

domenic · 2021-05-21T19:06:02Z

LGTM! Just waiting on bugs and tests then.

domenic · 2021-06-14T21:47:11Z

Any update on tests and bugs? /cc @hiroshige-g

This CL adds a test to confirm that, when page gets into and out of BFCache, - Focus should be kept and - blur/focus events are not fired. The current results are Safari: Pass Firefox: Focus remains the same but blur/focus events are fired. Chrome: Focus is lost. See whatwg/html#6696 for other status and implementation bug links etc. Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb

This CL adds a test to confirm that, when page gets into and out of BFCache, - Focus should be kept and - blur/focus events are not fired. The current results are Safari: Pass Firefox: Focus remains the same but blur/focus events are fired. Chrome: Focus is lost. See whatwg/html#6696 for other status and implementation bug links etc. Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198456 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#968703}

This CL adds a test to confirm that, when page gets into and out of BFCache, - Focus should be kept and - blur/focus events are not fired. The current results are Safari: Pass Firefox: Focus remains the same but blur/focus events are fired. Chrome: Focus is lost. See whatwg/html#6696 for other status and implementation bug links etc. Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198456 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#968703}

This CL adds a test to confirm that, when page gets into and out of BFCache, - Focus should be kept and - blur/focus events are not fired. The current results are Safari: Pass Firefox: Focus remains the same but blur/focus events are fired. Chrome: Focus is lost. See whatwg/html#6696 for other status and implementation bug links etc. Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198456 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#968703}

…nd BFCache, a=testonly Automatic update from web-platform-tests [WPT] BFCache: focus should be kept around BFCache This CL adds a test to confirm that, when page gets into and out of BFCache, - Focus should be kept and - blur/focus events are not fired. The current results are Safari: Pass Firefox: Focus remains the same but blur/focus events are fired. Chrome: Focus is lost. See whatwg/html#6696 for other status and implementation bug links etc. Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198456 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#968703} -- wpt-commits: a1e49a05bf46345316fd04bb4b22e5e7e8d9bc70 wpt-pr: 31084

This CL adds a test to confirm that, when page gets into and out of BFCache, - Focus should be kept and - blur/focus events are not fired. The current results are Safari: Pass Firefox: Focus remains the same but blur/focus events are fired. Chrome: Focus is lost. See whatwg/html#6696 for other status and implementation bug links etc. Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198456 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#968703}

…nd BFCache, a=testonly Automatic update from web-platform-tests [WPT] BFCache: focus should be kept around BFCache This CL adds a test to confirm that, when page gets into and out of BFCache, - Focus should be kept and - blur/focus events are not fired. The current results are Safari: Pass Firefox: Focus remains the same but blur/focus events are fired. Chrome: Focus is lost. See whatwg/html#6696 for other status and implementation bug links etc. Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198456 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#968703} -- wpt-commits: a1e49a05bf46345316fd04bb4b22e5e7e8d9bc70 wpt-pr: 31084

This CL adds a test to confirm that, when page gets into and out of BFCache, - Focus should be kept and - blur/focus events are not fired. The current results are Safari: Pass Firefox: Focus remains the same but blur/focus events are fired. Chrome: Focus is lost. See whatwg/html#6696 for other status and implementation bug links etc. Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198456 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#968703} NOKEYCHECK=True GitOrigin-RevId: 60349a6da0ccfa946936e76665ccff67fc9eac22

Add notes for focus & non-"fully active" documents

f458d15

Fixes whatwg#5878. Clarifies that the focused element stays the same/not reset when a document's "full active" state changed, and no events (focus/blur) are fired

rakina mentioned this pull request May 19, 2021

Back-forward cache: Restoring focus #5878

Closed

domenic approved these changes May 19, 2021

View reviewed changes

domenic added the topic: focus label May 19, 2021

annevk reviewed May 20, 2021

View reviewed changes

source Show resolved Hide resolved

rakina added 2 commits May 20, 2021 17:38

Apply suggestions

ae32f6c

Add note for viewport

89eedb6

domenic force-pushed the main branch from 0947339 to 1b5099f Compare July 27, 2021 17:07

domenic merged commit 5d515fa into whatwg:main Oct 14, 2021

chromium-wpt-export-bot mentioned this pull request Oct 25, 2021

[WPT] BFCache: focus should be kept around BFCache web-platform-tests/wpt#31084

Merged

domenic mentioned this pull request Nov 18, 2021

Focus management for SPA navs WICG/navigation-api#190

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add notes for focus & non-"fully active" documents #6696

Add notes for focus & non-"fully active" documents #6696

rakina commented May 19, 2021 •

edited by domenic

Loading

domenic May 19, 2021

rakina May 20, 2021

domenic May 20, 2021

rakina May 20, 2021

annevk left a comment

domenic commented May 21, 2021

domenic commented Jun 14, 2021

Add notes for focus & non-"fully active" documents #6696

Add notes for focus & non-"fully active" documents #6696

Conversation

rakina commented May 19, 2021 • edited by domenic Loading

domenic May 19, 2021

Choose a reason for hiding this comment

rakina May 20, 2021

Choose a reason for hiding this comment

domenic May 20, 2021

Choose a reason for hiding this comment

rakina May 20, 2021

Choose a reason for hiding this comment

annevk left a comment

Choose a reason for hiding this comment

domenic commented May 21, 2021

domenic commented Jun 14, 2021

rakina commented May 19, 2021 •

edited by domenic

Loading