Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate focus handling logic from <popup> to Element [popup 7/7] #33437

Merged
merged 1 commit into from
Apr 1, 2022

Commits on Apr 1, 2022

  1. Migrate focus handling logic from <popup> to Element [popup 7/7]

    This moves the focus management stuff out of HTMLPopupElement and into
    Element, to work with both <popup> and <div popup>.
    
    With this CL, all of the WPTs now pass, with the exception of the one
    for the anchor IDL property, which is an open issue [1].
    
    [1] openui/open-ui#382
    
    Bug: 1307772
    Change-Id: I0f475b52b1a14a910d267c7b681327f2e08976ac
    Cq-Do-Not-Cancel-Tryjobs: true
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561291
    Reviewed-by: David Baron <dbaron@chromium.org>
    Auto-Submit: Mason Freed <masonf@chromium.org>
    Commit-Queue: David Baron <dbaron@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#988069}
    mfreed7 authored and chromium-wpt-export-bot committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    3f553bb View commit details
    Browse the repository at this point in the history