Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename showPopup->showPopUp and hidePopup->hidePopUp #34570

Merged
merged 1 commit into from
Jun 24, 2022

Commits on Jun 24, 2022

  1. Rename showPopup->showPopUp and hidePopup->hidePopUp

    Per the resolution [1] and associated discussion [2] we need to
    rename showPopup to showPopUp, and hidePopup to hidePopUp. With
    the new scheme, the API is the "Pop up API", not the "Popup API".
    
    Note that this CL only changes the publicly-visible API from
    "popup" to "popUp", but leaves many internal references such as
    kPseudoPopupHidden instead of kPseudoPopUpHidden. crbug.com/1338587
    tracks that follow-on work, which I'll do once this change is
    validated as being web compatible.
    
    [1] openui/open-ui#546 (comment)
    [2] openui/open-ui#549
    
    Bug: 1307772
    Bug: 1338587
    Change-Id: Iaa28d4c1b7d526bb0b06c04eaec2fad5d0431746
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3717194
    Reviewed-by: David Baron <dbaron@chromium.org>
    Auto-Submit: Mason Freed <masonf@chromium.org>
    Commit-Queue: Mason Freed <masonf@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1017676}
    mfreed7 authored and chromium-wpt-export-bot committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    5ef26b2 View commit details
    Browse the repository at this point in the history