Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request upload: test synchronous feature detect #36048

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

jakearchibald
Copy link
Contributor

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks good to me, but I am not sure if this will actually have the intended outcome, as the implementer may just see this as "just another test failure for an unimplemented feature".

I can't think of anything better, and it definitely does not do any harm, so let's just land it.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me modulo nit.

assert_true(duplexAccessed, `duplex dictionary property should be accessed`);
}, "Synchronous feature detect");

// The asserts the synchronousFeatureDetect isn't broken by a partial implementation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// The asserts the synchronousFeatureDetect isn't broken by a partial implementation.
// This asserts the synchronousFeatureDetect isn't broken by a partial implementation.

?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about this nit... Maybe fix in a follow-up?

@annevk
Copy link
Member

annevk commented Sep 26, 2022

FWIW, I suspect as part of implementing Fetch features WebKit would sync fetch/ tests and thus this would be noticed at the relevant time.

annevk pushed a commit to whatwg/fetch that referenced this pull request Sep 26, 2022
@annevk annevk merged commit 9841e79 into master Sep 26, 2022
@annevk annevk deleted the fetch-streaming-request-feature-detect branch September 26, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants