Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request duplex property #36051

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Request duplex property #36051

merged 2 commits into from
Sep 26, 2022

Conversation

jakearchibald
Copy link
Contributor

Tests for whatwg/fetch#1493.

Doesn't feel like it needs any more than this?

@jakearchibald jakearchibald mentioned this pull request Sep 23, 2022
Merged
3 tasks
annevk
annevk approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we want to check that this indeed removes the throwing aspect when using a Request as a dictionary, but in a way that's already tested I suppose.

@annevk annevk merged commit 8fdd0c4 into master Sep 26, 2022
@annevk annevk deleted the request-duplex-property branch September 26, 2022 15:04
annevk pushed a commit to whatwg/fetch that referenced this pull request Sep 26, 2022
@jakearchibald
Add duplex property to Request
1fbc40c 
Oversight of #1457.

Tests: web-platform-tests/wpt#36051 & web-platform-tests/wpt#36048.

Closes #1486.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@annevk annevk annevk approved these changes

@jdm jdm Awaiting requested review from jdm

@mnot mnot Awaiting requested review from mnot

@youennf youennf Awaiting requested review from youennf

@yutakahirano yutakahirano Awaiting requested review from yutakahirano

Assignees

@yutakahirano yutakahirano

Labels
fetch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jakearchibald @annevk @lucacasonato @yutakahirano @wpt-pr-bot @moz-wptsync-bot