Add tests for feature detection logic #43188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 15, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5034265
branch
from
3f4fe38
to
3b89040
Compare
I'll be removing the feature flag in a subsequent CL now that we've shipped, so I don't test the flag off case. More context on the feature detection method at WICG/turtledove#803 Bug: 1462720 Change-Id: Ica63b282e3c380aa09f2ee8a6fc93e89ae9ce21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5034265 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/main@{#1225565}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5034265
branch
from
3b89040
to
0eae995
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll be removing the feature flag in a subsequent CL now that we've
shipped, so I don't test the flag off case.
More context on the feature detection method at
WICG/turtledove#803
Bug: 1462720
Change-Id: Ica63b282e3c380aa09f2ee8a6fc93e89ae9ce21f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5034265
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1225565}