Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for feature detection logic #43188

Merged
merged 1 commit into from
Nov 16, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions fledge/tentative/direct-from-seller-signals.https.window.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,14 @@ subsetTest(promise_test, async test => {
await runReportTest(
test, uuid,
directFromSellerSignalsValidatorCode(
uuid, /*expectedSellerSignals=*/null,
/*expectedAuctionSignals=*/null, /*expectedPerBuyerSignals=*/null),
uuid, /*expectedSellerSignals=*/ null,
/*expectedAuctionSignals=*/ null, /*expectedPerBuyerSignals=*/ null),
// expectedReportUrls
[createSellerReportURL(uuid), createBidderReportURL(uuid)],
// renderURLOverride
null,
// auctionConfigOverrides
{ directFromSellerSignalsHeaderAdSlot: 'adSlot/0'}
);
{directFromSellerSignalsHeaderAdSlot: 'adSlot/0'});
}, 'Test directFromSellerSignals with empty Ad-Auction-Signals header.');

subsetTest(promise_test, async test => {
Expand Down Expand Up @@ -495,3 +494,11 @@ subsetTest(promise_test, async test => {
{ directFromSellerSignalsHeaderAdSlot: 'adSlot' }
);
}, 'Test directFromSellerSignals with network error.');

subsetTest(promise_test, async test => {
let dfss = false;
navigator.runAdAuction({
get directFromSellerSignalsHeaderAdSlot() { dfss = true; }
}).catch((e) => {});
assert_true(dfss);
}, 'Test directFromSellerSignals feature detection.');