Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test parse-time HSL clamp of negative saturation to zero #44269

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Test parse-time HSL clamp of negative saturation to zero #44269

merged 1 commit into from
Feb 14, 2024

Conversation

svgeesus
Copy link
Contributor

@dbaron
Copy link
Member

dbaron commented Jan 29, 2024

Looks like it's not as interoperable as w3c/csswg-drafts#9222 (comment) suggests, since the new tests pass in Firefox but three of them fail in Chrome. Is that expected?

@svgeesus
Copy link
Contributor Author

The new tests pass in Firefox but three of them fail in Chrome. Is that expected?

Not expected; the test values and expected values are from a test you wrote and the only difference is that your earlier CSS Color 3 test used legacy syntax, while the new addition to the CSS Color 4 test use modern syntax.

However I think the difference here is that Chrome is not accepting a mix of <number> and <percentage>, while Firefox is correctly allowing it for modern syntax. So that would be a Chrome bug.

@svgeesus
Copy link
Contributor Author

@svgeesus svgeesus marked this pull request as draft January 30, 2024 19:57
@svgeesus
Copy link
Contributor Author

@dbaron this is seemingly a regression between Chrome 120 and Chrome 121 but I have made this PR a draft so CSSWG can decide on what behavior we want before this test change lands/doesn't land.

Copy link
Member

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on discussion in w3c/csswg-drafts#9222 this looks good.

@svgeesus svgeesus marked this pull request as ready for review February 14, 2024 19:14
@svgeesus svgeesus merged commit 2736c7f into web-platform-tests:master Feb 14, 2024
18 checks passed
@svgeesus svgeesus deleted the hsl-parse-clamp-negative-saturation branch February 14, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants