Change namespace for Trusted-Types tests for setAttributeNS to null
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a test, which was accidentally lost while renaming in PS8 of crrev.com/c/5251158. The content is the same as the one in PS7. Bug: 1520442 Change-Id: Ie9b72f63a9560b803f7cd3120c45cc3071302405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5261043 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255506}
This fixes a bug where dispatching an InvokeEvent with a null invoker will cause a nullptr exception as it tries to retarget the Invoker based on the currentTarget. The fix returns early nullptr if invoker is a nullptr, which also skips the CHECK_EQ on eventPhase(), as just guarding the Retarget call would skip to this check which would cause the check to fail if invoker was retrieved during the bubbling phase. Bug: 1511341 Change-Id: I6e0e250a47466a502daeb8ab32335ff1521edc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5260418 Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Keith Cirkel <chromium@keithcirkel.co.uk> Reviewed-by: David Baron <dbaron@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255591}
All element reflection IDL attributes must have their attribute name return true in IsElementReflectionAttribute, or else the attribute and javascript getter will not be kept in sync. This patch adds the popovertarget and anchor attributes to that list and also adds a DCHECK to make sure that when the generated IDL code sets an element attribute, that attribute is listed in IsElementReflectionAttribute. Fixed: 1523410 Change-Id: I919153b894884507530b2bb219c4cbf7327780a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5260611 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255605}
The timeout is the likely culprit. If the test flakes again, we should put the TestExpectations entry back and re-investigate. Bug: 1430215 Change-Id: I27d450e37920072d04018b1e191b8e7efb1867dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5262097 Commit-Queue: David Awogbemila <awogbemila@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255607}
Intent-to-ship: https://groups.google.com/u/2/a/chromium.org/g/blink-dev/c/S67zJ1AYW2U Bug: 1466250 Change-Id: Idfa99b35a900440beb53b1c6a7a7af8bee2a66c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5261861 Commit-Queue: Khushal Sagar <khushalsagar@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255674}
This reverts commit 572074cb06425797e7e110511db405134cf67e2f. Reason for revert: caused regression bug: crbug.com/1521614 Original change's description: > Remove empty closed paths > > As discussed in the github issue, > whatwg/html#1079, it's generally agreed to > skip drawing line caps for closed paths. This is a follow up cl of: > https://chromium-review.googlesource.com/c/chromium/src/+/4864061. > > In this cl, it verifies if each closed path is empty, then it removes > the empty closed subpaths from path. As the subpaths are removed, the > corresponding line caps are skipped. > > Bug: 644067 > > Change-Id: I14c5c4819a31eb9249d01574ff1b5c60826c3b9e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4916516 > Commit-Queue: Yi Xu <yiyix@google.com> > Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org> > Reviewed-by: Justin Novosad <junov@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1247735} Bug: 644067 Change-Id: I33ecfd76574d6f60e6f8c471a38183f87757e3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5258624 Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org> Commit-Queue: Yi Xu <yiyix@google.com> Cr-Commit-Position: refs/heads/main@{#1255711}
This test doesn't actually work since it references an idl file which isn't defined. I manually verified that the CustomStateSet idl is already tested by external/wpt/html/dom/idlharness.https.html so there is no need for this separate test file anymore. Change-Id: If4aca93159724cdb9e7d007933635a2d55d06f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5253030 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255766}
This patch forbids nested <button>s and <datalist>s to avoid setting kInSelectMode while we are technically still in a <button> or <datalist>. This patch also replaces a call to SetInsertionMode() with ResetInsertionModeAppropriately() and moves it after processing the end tag in order to avoid ending up in kInSelectMode when there is not actually an open <select> tag. The clusterfuzz crash didn't have a minimal repro but I manually verified that the crash does not repro with this patch. Bug: 1511354 Fixed: 1519396 Change-Id: I4358973b36925ea0862f4050f27f804d2676288c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5254124 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255770}
Per spec: https://html.spec.whatwg.org/multipage/rendering.html#bidi-rendering this should be in the UA stylesheet: address, blockquote, center, div, figure, figcaption, footer, form, header, hr, legend, listing, main, p, plaintext, pre, summary, xmp, article, aside, h1, h2, h3, h4, h5, h6, hgroup, nav, section, search, table, caption, colgroup, col, thead, tbody, tfoot, tr, td, th, dir, dd, dl, dt, menu, ol, ul, li, bdi, output, [dir=ltr i], [dir=rtl i], [dir=auto i] { unicode-bidi: isolate; } To avoid breakage, I just added the elements, and not the [dir] related rules, nor did I change the <bdo> rules. Firefox and WebKit are both making the same change: https://bugzilla.mozilla.org/show_bug.cgi?id=1874033 https://bugs.webkit.org/show_bug.cgi?id=267887 The stylesheet change interacts with the code at [1], and that code also handles some of the cases such as [dir=auto] and bdi/bdo. I will clean up some of the code at [1] in a followup CL. [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/html_element.cc;l=344-363;drc=20fecf94cc2226674dfefd698e96d8d44485b19c Fixed: 1520671 Change-Id: Icaa32061efc59d963942b0629327bb596ac224ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5240082 Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255819}
When the canvas has to be presented while layers are opened, we cannot present the layer content, but we can present any painting that happened before the top most layer was opened. To do so, the recording has to be split into two parts: a main recording and a side recording. The side recording holds the content of all nested layers in one single recording. When the top most layer is closed, the content of the side recording is written to the main recording. Bug: 1484741 Change-Id: Id32412819c0395edd501243b2ccead30ebc0b674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5113500 Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Reviewed-by: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255834}
The change adds MP4 mime type to the relevant tests on the MediaRecorder tests where the test reached to the muxer level. There is a bug that block the change of 'PMediaRecorder-peerconnection.https.html', which will be handled with bug fix of 1523375. Bug: 1072056 Change-Id: Ie3c2c306bb454e1eb8914047137c6a5844bcdfdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5250746 Commit-Queue: Sunggook Chue <sunggch@microsoft.com> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255836}
…s#44345) Adds tests for `race-network-and-fetch-handler`, which is the service worker static routing API's router source option. This tests check the case when the network request wins and the fetch handler wins the race respectively, both for the main resource and subresource. Bug: 1519727 Change-Id: I19fe304c294f64d99d08c76be113a41d726b8d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5256919 Commit-Queue: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255046} Co-authored-by: sisidovski <sisidovski@chromium.org>
…m-tests#44372) Only in cases where there is not a single pointer event registered on a page, blink may entirely optimize out EventDispatch steps, since there are no observers anyway. This optimization should not normally be detectable. However, the Event Timing API still measures these events and reports them to the performance timeline. Because the EventDispatch steps are where we assign EventTarget to Event objects, the Event Timing API was effectively missing the target value whenever we skipped this step. This patch plumbs the original HitTest target which we fall back to under such situations. Bug: 1367329 Change-Id: Icf21e6103c98261e9f6e88cef1ac09f3a683751b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5246848 Commit-Queue: Michal Mocny <mmocny@chromium.org> Reviewed-by: Aoyuan Zuo <zuoaoyuan@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255634} Co-authored-by: Michal Mocny <mmocny@chromium.org>
Nightly-only for now waiting on CSSWG discussion. Differential Revision: https://phabricator.services.mozilla.com/D199727 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1868316 gecko-commit: 6fdde7dce00345bc568706b0cf7de521b91ba75a gecko-reviewers: jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D200523 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1144434 gecko-commit: e6b6322cf7a97bfef714c3e1c901937546fb740f gecko-reviewers: TYLin
…ts#44361) * Add null-check to aria_utils verifyLabelsBySelector Before this commit, verifyLabelsBySelector calls test_driver.get_computed_label and then does string-manipulation on the result. For some reason, this get_computed_label invocation returns null in Firefox, and so the string-manipulation causes a JS exception to be thrown, which makes for awkward test failure results. Let's just explicitly assert that the result is not-null, to make that expectation clearer and to give a cleaner test-failure in cases where it is unexpectedly null.
Before this CL, in the renderer, registered routers are not evaluated if there is no fetch handler in the service worker. This is critical and introduces unexpected behavior for the static routing API, because developer may only use static routing API, that doesn't guarantee the fetch handler existence. This CL add the new boolean field, `need_router_evaluate` to ControllerServiceWorkerInfo mojo interface. The renderer side use this field to decide whether it involves ServiceWorkerSubresourceLoader or not. Bug: 1511459 Change-Id: I88e09900931a149c78cc4f25015fa5a5b1ffd62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5252809 Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Minoru Chikamune <chikamune@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/main@{#1256065}
This tests color of `<mtext href>` links. Although links were mentioned in a previous draft of MathML Core, they have been removed from the current version and adding them back is pending consensus. However, upstream WPT still contains tests for MathML links so it makes sense to have all of these tentative tests. This commit exports `link-001.html` as a tentative mismatch reftest with proper renaming (note that the `<link rel="mismatch">` refers to a non-existent `link-color-001-ref.xhtml` file). Similarly, all the existing tests assuming support for `href` are renamed as 'tentative' tests. Finally, we also remove a few annotations from bug 1798871. There is no behavior change. Differential Revision: https://phabricator.services.mozilla.com/D200441 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1876684 gecko-commit: 5ec8a1a095532086defe3180d8ca1d16cd53df20 gecko-reviewers: emilio
- mpadded-1/2/3.html, mpadded-1-2.html: These are testing visual rendering of two nested mpadded elements with basic attribute values that are accepted by MathML Core. - mpadded-4.html: This is testing mpadded attribute with pseudo units, which are not supported by MathML Core, so convert to internal WPT test. - mpadded-5/6: These are testing negative values of some mpadded attributes whose interpretation or support is unclear in MathML Core. So convert to internal WPT tests for now. Differential Revision: https://phabricator.services.mozilla.com/D200442 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1876684 gecko-commit: a55c77e16ea8c476eee487f52739314d54a3c39a gecko-reviewers: emilio
Differential Revision: https://phabricator.services.mozilla.com/D200542 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1232875 gecko-commit: fd1e72bb806598ff45f5c53732b3a63286505aeb gecko-reviewers: layout-reviewers, emilio
The test that "credential" will be a DOMString turned out to be a failure because any Javascript object can be converted to the string "[Object object]". The referenced part of the specification isn't there any more. Bug: None Change-Id: Ie6a08a24f76e7a895517feef587ff31ecfe2fdac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5266622 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1256182}
Signed-off-by: syvb <me@iter.ca>
The only time we need hidden nodes is when they are part of a label or description. This CL keeps track of whether a given node has ever been part of a label or description. If the node is hidden, it removes it from the tree unless it's needed for a label/description. In combination with CL:4852390, which removes hidden line breaks, reduces the time spent in serialization and deserialization by massive amounts in tests that involve heavy usage of hidden subtrees. For the specific results, see: https://docs.google.com/spreadsheets/d/1ozLJMRT32yIxE0ja0rDhdZPb76hQtDd0klcRcR_uWYU/edit?pli=1#gid=0 This will make a significant difference in web apps with panels, chats, slides, etc. where a significant percentage of the content is hidden. Bug: 1448706, 1353788 Cq-Include-Trybots: luci.chromium.try:fuchsia-x64-accessibility-rel,linux-blink-web-tests-force-accessibility-rel Change-Id: I1b0de1d9b6f037c107efd3ca93c073382fd0ece1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574033 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1256230}
Checkboxes support validity via the required attribute and the other browsers support :user-valid/:user-invalid on them. The existing :user-valid/:user-invalid machinery only works on text fields, so this patch adds some code to checkboxes to make them work as well. Fixed: 1521781 Change-Id: I91309f36348470db5b1c706b519e6303e5deeab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5258739 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1256264}
As per spec, sourceURL / sourceFunctionName / sourceCharPosition Amended existing test. Bug: 1523675 Change-Id: Ic3bb8df05bb822fa8b56990e2696d67324b4763f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5250540 Reviewed-by: Ian Clelland <iclelland@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: Michal Mocny <mmocny@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1256409}
This includes tests to confirm size/cols/rows are not presentational hints. Issue: whatwg/html#6807
…ld clear the explicitly set attr-element. Differential Revision: https://phabricator.services.mozilla.com/D201711 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1879001 gecko-commit: 6f0ebcced75f999a360fdd4f2e00d66fe811dc84 gecko-reviewers: emilio
…b-platform-tests#44643) WebKit will reject the single colon syntax in `getComputedStyle()` because it is invalid.
…3751) Add tests to ensure that the Ed25519 Verify implementation performs checks for small-order keys and signature's point R. Additionally, add tests for mixed-order points, and check that the cofactorless (unbatched) verification equation is used, as required by the latest draft.
Upstream added a new test which would trigger MISSING-LINK error. Bug: None Change-Id: I556ce91304fdcc09b616a505dfa7bf149a53e7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5308374 Commit-Queue: Weizhong Xia <weizhong@google.com> Auto-Submit: Weizhong Xia <weizhong@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1262474}
Per the HTML-AAM spec, the contextual role restriction only applies to the <footer> element, not to any other instance of the ARIA contentinfo role. Even though <footer> maps to contentinfo, contentinfo does not necessarily map to <footer>. Thus, this test is incorrect. Differential Revision: https://phabricator.services.mozilla.com/D201928 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1878363 gecko-commit: 5c67e50b735884a798f9a9c29b9117a1fc696ebe gecko-reviewers: nlapre
Asserting the "and also MUST include all currently available formats" https://www.rfc-editor.org/rfc/rfc8829.html#name-subsequent-offers See w3c/webrtc-pc#2938 BUG=None Change-Id: I7748ea94e58ba93cdf1043ee0235a7e560e260e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5293377 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262601}
For non-OOF elements, we currently implement a used-value time conversion of any length with anchor queries: the inset and sizing properties become their initial value whenever we have an anchor query. The spec is (now) very clear on how this should work: we should always just use the fallback value of the query. Note that all anchor queries have a fallback value: it set to 0px if not provided by the author. Fixed: 325990051 Change-Id: If3f38b45c8235237dbf6c62b366ef184e267d82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5307086 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262701}
This test wasn't waiting long enough for the close event to fire, but by adding a rAF, it always fires. Fixed: 325336527 Change-Id: I916c129d97567576abe0a79d2e6b136fb9f07e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5303730 Auto-Submit: Joey Arhar <jarhar@chromium.org> Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Di Zhang <dizhangg@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262711}
Change-Id: I6fea432648d8be7c5d4de8cd9da1b6593f0d667e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5189771 Reviewed-by: Ben Kelly <wanderview@chromium.org> Commit-Queue: Anton Maliev <amaliev@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262741}
This is a reland of commit a3e84dde09e099bebbe4793ffaa70679168130d6 This CL contains a few additional changes: - Enables the async APIs on workers, which was causing bots to fail since workers could not call createContext() - Rebaselines WPTs accordingly - Updates the WPT expectations for the webnn-service-enabled virtual test suite Original change's description: > webnn: Remove sync methods > > See webmachinelearning/webnn#548 > > Deletes all sync methods and simplifies the names of all "Async" > methods - e.g. BuildAsync() -> Build() > > Bug: 40283536, 41481333 > Change-Id: I3b38d987cb4641ea41ab9a974c46dcba16d5c108 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5292884 > Commit-Queue: Austin Sullivan <asully@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: ningxin hu <ningxin.hu@intel.com> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1261223} Cq-Include-Trybots: luci.chromium.try:win11-x64-fyi-rel Bug: 40283536, 41481333, 41485898 Change-Id: Iffcb922b8175a7181deba1f4c2faa953010ae5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5303774 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262043} Co-authored-by: Austin Sullivan <asully@chromium.org>
Bug: 41494232 Change-Id: Ib5034ff7e6617334cfa51add578a4636a4250e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5290856 Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262340}
The sign() function is already speced, so without progress() the tests should not be marked tentative. Bug: 41494232 Change-Id: I8ba597670028749d9a76cc97ddf8e4e2befc7781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5307215 Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262345}
to supplement the discussion in w3c/webrtc-pc#2937 BUG=324930413 Change-Id: Iebf02aade64030e11590af211fa7bc90f976c592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5293562 Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262367}
The svg/paintorder/paintorder-text-decorations.svg test was recently exported to WPT by an external party, and now exists as external/wpt/svg/painting/reftests/paintorder-text-decorations.svg. Reformat and export the rest of svg/paintorder as well. Change-Id: I0b444f5dc44206caf37f5586ac0789b69d7f91ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5307408 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/main@{#1262817}
Differential Revision: https://phabricator.services.mozilla.com/D202084 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1880689 gecko-commit: a2d20caae947dbcca9ffbeeca241acbae7900fed gecko-reviewers: emilio
This was noted here: web-platform-tests/interop#423 (comment) Bug: 40059176 Change-Id: I58f3674d2901b8ca7df4c5d5ba8ed99c0b62a4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310497 Commit-Queue: Di Zhang <dizhangg@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262923}
This includes two changes: 1. Rename includeShadowRoots to serializableShadowRoots 2. Do not throw an exception if serializableShadowRoots is false but shadowRoots is non-empty. I also added IDL defaults for both parameters to clean up the C++. I also added a test of the use counter for getHTML(). Bug: 41490936 Change-Id: Ieedd81b5165d9652c3a7b68dea4a4fa5fb088560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5304121 Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Reviewed-by: Di Zhang <dizhangg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262930}
Otherwise we might end up with multiple fragments for the same OOFs in the same fragmentainer. This bug got introduced by https://crrev.com/c/5134653 , which made sure that inner multicol info got propagated correctly also when cloning or mutating an outer fragmentainer (when adding OOFs). Keep a list of handled inner multicols, so that we only visit them once. For this list to work, we need to stop calling HandleMulticolsWithPendingOOFs() recursively from LayoutOOFsInMulticol(). Bug: 4148620 Change-Id: I337da660834f5f44115509ab8d4a236be7ad1dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5307146 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1262934}
This patch invalidates layout and paint when UsesStandardScrollbarStyle changes. This fixes an issue where adding scrollbar-color to an element with ::-webkit-scrollbar styles causes the legacy scrollbar to disappear without repainting the new standard one. Bug: 41497285 Change-Id: I119bb4f96c06ef4efdcd985107c0be448c55dcd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310160 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Luke <lwarlow@igalia.com> Cr-Commit-Position: refs/heads/main@{#1263072}
Bug: 324939068 Change-Id: Ie3f43cb510c41930991f3704427b44a79d86d881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5307317 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#1263113}
This is a partial implementation, as some of the stats fields are still under discussion in the W3C WG. Bug: 1519563 Change-Id: I2949cb3cf8d31bd87b87599520417707a66bceaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4953098 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#1263183}
Differential Revision: https://phabricator.services.mozilla.com/D201086 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1870037 gecko-commit: 2ffbf643b4822b977fd141db609b53abe3989151 gecko-reviewers: webidl, smaug
See whatwg/html#10150. Per spec these run even if the attribute doesn't change. Differential Revision: https://phabricator.services.mozilla.com/D202240 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1881075 gecko-commit: 2c4646b33c7313f86fb6fb60be42fb5fcb5f106b gecko-reviewers: zsun
To confirm that SharedWorker blob URL inherits the ServiceWorker controller, this CL adds a WPT to confirm that. Note that we know that Chromium does not pass this test due to crbug.com/40364838. Bug: 324939068 Change-Id: Ief9e00eb798eb446f299910a1403651a86c7950c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5312920 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/main@{#1263190}
Bumps [selenium](https://github.com/SeleniumHQ/Selenium) from 4.14.0 to 4.18.1. - [Release notes](https://github.com/SeleniumHQ/Selenium/releases) - [Commits](SeleniumHQ/selenium@selenium-4.14.0...selenium-4.18.1) --- updated-dependencies: - dependency-name: selenium dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
mbrodesser-Igalia
changed the title
setAttributeNS to null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
animations/transition-timing-function.htmltext-wrap: prettyparsing tests (Split outtext-wrap: prettyparsing tests web-platform-tests/wpt#44335)wpttest.{Test -> (Subtest)Result}web-platform-tests/wpt#44424) serial: Migrate Web Serial MojoJS based tests to internal folder [wdspec] Add invalid test for browsingContext.create with removed userContext [wdspec] Add test for browser.removeUserContext to check browsing contexts are closed Add tests for zstd content-encoding (Add tests for zstd content-encoding web-platform-tests/wpt#44393) [wdspec] Add type hint parameter for context_created and context_destroyed user context tests [wdspec] Always assert user context in assert_browsing_context [wdspec] Add various user_context tests for browsingContext.create Make declarative shadow roots of custom elements available to element internals. Moved position-try-order into wpt/ from wpt_internal/ Fully implement bidi for a line's trailing spaces (UAX#9 L1) DOM: Implement the forEach() Observable operator Make nsRange delete itself from Selections if it becomes a range in different root Follow shortest serialization principle for transition shorthand. Only record that breakPriority indicated use of overflow-wrap if we actually needed to break the text. Do not call CreateAndShow with the default permission [shared storage] Allow creating multiple worklets per Window context [EditContext] Ensure textupdate fires for backspace/delete in Correctly handle printing of overflowing monolithic OOFs. allow old headless mode for chrome (allow old headless mode for chrome web-platform-tests/wpt#44445) Zoom should affect intrinsic replaced element size. [wdspec] Extend timeout for network/continue_response/invalid.py and network/continue_request/invalid.py Part 2 - support SVG properties on first-letter and first-line Always call superclass in HTMLLabelElement::DefaultEventHandler Use OK status to check RaceNetworkRequest response Move monolithic-overflow- from css/printing to css/css-page. (Move monolithic-overflow-* from css/printing to css/css-page. web-platform-tests/wpt#44422)* Fix offset APIs on tables with captions.* use ssl.SSLContext.wrap_socket rather than the deprecated ssl.wrap_socket Add coverage for webkit prefixed historical interface (Add coverage forwebkitprefixed historical interface web-platform-tests/wpt#44462) [css-anchor-position] Parsing and computing position-try-options Establish display item fragment scope for atomic inlines. Implement view-transition-class selector matching Test to account for links wrapped in svg (Test to account for links wrapped insvgweb-platform-tests/wpt#44461) sensors: Make virtual sensors always remember and report the latest reading VT: Handle document shutdown gracefully. [Grid] Fix resolution of alignment properties for subgridded items Implement :open and :closed pseudo classes Add tests for CSS calc-size() function. Add tests for animation of CSS calc-size(). [css-anchor-position] Add interpolation tests for all properties [wdspec] Add test for early fetchError events Part 4: Implement generic role mapping Make Element.{client Slightly adjust threshold in oscillator and compressor test in WPT for new FFT code. Fix focus gets incorrectly cleared by PresShell::FixUpFocus if the focus is on area element DOM: add some CDATASection coverage [css-nesting] Don't emit invisible rules inside @page Add test from issue 40650780 Remove unnecessary header for fetch requests A non-invertible gradient/patternTransform make the paintserver invalid Don't reset the subpath start on 'close' commands Close the dialog element when the open attribute is removed [HitTestTransparency] Experimental status Request::Contructor init body now takes precendence over input body. FLEDGE: field trial testing config for 20->40 in component ads limit Export made from a WebKit repository Convert existing orientation-event web tests to test_driver [wptrunner] Use the correct ProfileCreator class in FirefoxAndroidWdSpecBrowser. Make PresShell::EventHandler::DispatchPrecedingPointerEvent update event target after dispatching a pointer event Change the behavior of clonable to be more opt-in Revert "FLEDGE: field trial testing config for 20->40 in component ads limit" [marionette] Implicitly accept "beforeunload" prompts in Marionette. webrtc wpt: update RTCRtpParameters-codec.html to use receive-side setCodecPreferences Remove Microsoft Edge Legacy (Remove Microsoft Edge Legacy web-platform-tests/wpt#44233) [anchor] Remove anchor(auto) Add support for math expressions for offset-rotate interpolation Add support for math expressions in custom properties angle interpolation Add basic @page (CSSPageRule) CSSOM test. [multicol] Allow stretch sizes to resolve for column balancing. Reland "FLEDGE: field trial testing config for 20->40 in component ads limit" [Async Clipboard] Use supports instead of IsValidType. Document render-blocking: use classic scripts to generate parser delay Add CSS display-mode experimental support for picture-in-picture Event Timing - Handle modal dialog interference Add 'writingsuggestions' attribute Make Shift + right click should work as a right click without Shift if contextmenu should forcibly be open Make sure we hold a reference to the pc in these tests. Wait for RTP before checking for RTP stats. Make --headless the default for Chrome and Chromium (Make --headless the default for Chrome and Chromium web-platform-tests/wpt#44515) [shared storage] Introduce WorkletOptions param VT: Add class list as a specificity consideration for view transitions. Fenced frames: Disable _unfencedTop navigations after network revocation Fix typo in MediaRecorder-mimetype.html Add iframes lazy load scroll margin wpt tests Remove IE App (Remove IE App web-platform-tests/wpt#44344) Clean up CompareTreePosition and related code. Part 2 - Add :has to revalidation selector. Add @page (CSSPageRule) CSSOM test for adding / removing properties. Do feature detection in @starting-style tests Add support for math expressions for border-image-width interpolation Add support for math expressions for font-stretch interpolation Add support for math expressions for font-size-adjust interpolation [wdspec] Fix escaping in test_shadow_root_slot[default hidden]. Add fuzzy metadata to wpt/svg/painting/reftests/marker-path-001.svg Field trial testing config for sampling debug reports. [SAA] Implementing SharedWorker support (Part 3: Implement same-site cookie filtering) webrtc wpt: fix and re-enable getStats WPT (webrtc wpt: fix and re-enable getStats WPT web-platform-tests/wpt#44553) webrtc wpt: update more tests to use receiver capabilities for setCodecPreferences (webrtc wpt: update more tests to use receiver capabilities for setCodecPreferences web-platform-tests/wpt#44554) Fix manual assignment crashLineBreaker::SplitTrailingBidiPreservedSpacestorage.getCookiesandstorage.setCookiecommands.inert-iframe-hittest.htmlinitialize pointer position before adding event listenersanchorinto tentative testsetAttributeNStonull