Fenced frames: Disable popup navigations after network revocation #44552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5259509
branch
2 times, most recently
from
4f644d5 to
e521a89
Compare
Navigations into and out of fenced frames need to be treated specially for network revocation, because they don't have the revoked partition nonce attached. Previous CLs disabled embedder-initiated fenced frame root navigations and _unfencedTop navigations; this CL disables popup navigations. Bug: 1515599 Change-Id: Ia05e3fecb40240de1d32a3e736e42eba5f03f411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5259509 Reviewed-by: Dominic Farolino <dom@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Garrett Tanzer <gtanzer@chromium.org> Cr-Commit-Position: refs/heads/main@{#1260187}
wpt-pr-bot
approved these changes
Feb 14, 2024
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5259509
branch
from
e521a89 to
8b25ad1
Compare
|
WPT Command: Some affected tests had inconsistent (flaky) results: Unstable resultsTest | Subtest | Results | Messages -- | -- | -- | -- /shared-storage/shared-storage-writable-service-worker-img.tentative.https.sub.html | | ERROR: 9/10, TIMEOUT: 1/10 |These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag 61:35.80 INFO | `embedder sharedStorage.context with nested iframes` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/run-url-selection-operation.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |--------------------------------------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `selectURL() resolves to config` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO | `selectURL() with urls array length too big, selectURL() resolves to config` | FAIL | `assert_equals: expected "DataError" but got "ReferenceError"` | 61:35.80 INFO | `selectURL() with empty urls array, selectURL() resolves to config` | FAIL | `assert_equals: expected "DataError" but got "ReferenceError"` | 61:35.80 INFO | `selectURL() with missing url, selectURL() resolves to config` | FAIL | `assert_equals: expected "TypeError" but got "ReferenceError"` | 61:35.80 INFO | `selectURL() with invalid url, selectURL() resolves to config` | FAIL | `assert_equals: expected "DataError" but got "ReferenceError"` | 61:35.80 INFO | `selectURL() with invalid report url selectURL() resolves to config` | FAIL | `assert_equals: expected "DataError" but got "ReferenceError"` | 61:35.80 INFO | `selectURL() with http report url, selectURL() resolves to config` | FAIL | `assert_equals: expected "DataError" but got "ReferenceError"` | 61:35.80 INFO | `selectURL() with invalid reportingMetadata selectURL() resolves to config` | FAIL | `assert_equals: expected "DataError" but got "ReferenceError"` | 61:35.80 INFO | `selectURL() resolves to urn:uuid` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO | `selectURL() with urls array length too big, selectURL() resolves to urn:uuid` | FAIL | `assert_equals: expected "DataError" but got "ReferenceError"` | 61:35.80 INFO | `selectURL() with empty urls array, selectURL() resolves to urn:uuid` | FAIL | `assert_equals: expected "DataError" but got "ReferenceError"` | 61:35.80 INFO | `selectURL() with missing url, selectURL() resolves to urn:uuid` | FAIL | `assert_equals: expected "TypeError" but got "ReferenceError"` | 61:35.80 INFO | `selectURL() with invalid url, selectURL() resolves to urn:uuid` | FAIL | `assert_equals: expected "DataError" but got "ReferenceError"` | 61:35.80 INFO | `selectURL() with invalid report url selectURL() resolves to urn:uuid` | FAIL | `assert_equals: expected "DataError" but got "ReferenceError"` | 61:35.80 INFO | `selectURL() with http report url, selectURL() resolves to urn:uuid` | FAIL | `assert_equals: expected "DataError" but got "ReferenceError"` | 61:35.80 INFO | `selectURL() with invalid reportingMetadata selectURL() resolves to urn:uuid` | FAIL | `assert_equals: expected "DataError" but got "ReferenceError"` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/same-origin-add-module-credentials-include.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |------------------------------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `addModule() with same-origin module script and credentials "include"` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/same-origin-add-module-credentials-omit.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |---------------------------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `addModule() with same-origin module script and credentials "omit"` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/same-origin-add-module-credentials-same-origin.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |----------------------------------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `addModule() with same-origin module script and credentials "same-origin"` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/same-origin-create-worklet-credentials-include.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |----------------------------------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `createWorklet() with same-origin module script and credentials "include"` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/same-origin-create-worklet-credentials-omit.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |-------------------------------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `createWorklet() with same-origin module script and credentials "omit"` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/same-origin-create-worklet-credentials-same-origin.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |--------------------------------------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `createWorklet() with same-origin module script and credentials "same-origin"` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/select-url-keep-alive.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |-----------------------------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `selectURL() with keepAlive: true, then keepAlive: false, then error` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/select-url-on-shared-storage-and-worklet-object-successively.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |------------------------------------------------------------------------------------------------------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `selectURL() on window.sharedStorage and window.sharedStorage.worklet successively. The two calls should run in the same worklet environment.` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/select-url-on-two-worklets.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |-------------------------------------------------------------------------------------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `selectURL() on two explicitly created SharedStorageWorklet. The two calls should run in two different worklet environments.` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/select-url-report-event.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |--------------------------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `selectURL() with reportEvent(), selectURL() resolves to config` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO | `selectURL() with reportEvent(), selectURL() resolves to urn:uuid` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-clear.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |----------------------------------------------------------------------------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------| 61:35.80 INFO | | TIMEOUT | | 61:35.80 INFO | `Clearing from shared storage via the 'Shared-Storage-Write' header for a same-origin shared storage fetch request` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO | `Clearing from shared storage via the 'Shared-Storage-Write' header for a cross-origin shared storage fetch request` | TIMEOUT | `Test timed out` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-delete.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |----------------------------------------------------------------------------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------| 61:35.80 INFO | | TIMEOUT | | 61:35.80 INFO | `Deleting from shared storage via the 'Shared-Storage-Write' header for a same-origin shared storage fetch request` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO | `Deleting from shared storage via the 'Shared-Storage-Write' header for a cross-origin shared storage fetch request` | TIMEOUT | `Test timed out` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-forbidden-header-tentative.https.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |----------------------------------------------------------------------------------------------------------------------------|---------|------------------| 61:35.80 INFO | | TIMEOUT | | 61:35.80 INFO | `The 'Sec-Shared-Storage-Writable' header cannot successfully be added directly via a JS fetch request with mode cors.` | TIMEOUT | `Test timed out` | 61:35.80 INFO | `The 'Sec-Shared-Storage-Writable' header cannot successfully be added directly via a JS fetch request with mode no-cors.` | NOTRUN | | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-iframe-content-attribute.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |------------------------------------------------------------------------|---------|------------------| 61:35.80 INFO | | TIMEOUT | | 61:35.80 INFO | `test <iframe sharedstoragewritable src=[url]> for same origin iframe` | TIMEOUT | `Test timed out` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-iframe-idl-attribute-included.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |-----------------------------------------------------------------------------------------|---------|------------------| 61:35.80 INFO | | ERROR | | 61:35.80 INFO | `test <iframe sharedstoragewritable src=[url]></iframe> via JS for same origin iframe` | TIMEOUT | `Test timed out` | 61:35.80 INFO | `test <iframe sharedstoragewritable src=[url]></iframe> via JS for cross origin iframe` | NOTRUN | | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-iframe-idl-attribute-not-included.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |-------------------------------------------------------------------|---------|------------------| 61:35.80 INFO | | TIMEOUT | | 61:35.80 INFO | `test <iframe src=[url]></iframe> via JS for same origin iframe` | TIMEOUT | `Test timed out` | 61:35.80 INFO | `test <iframe src=[url]></iframe> via JS for cross origin iframe` | NOTRUN | | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-iframe-in-fenced.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |---------------------------------------------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `test <iframe sharedstoragewritable src=[url]></iframe> via JS inside a fenced frame` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-img-content-attribute.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |------------------------------------------------------------------|---------|------------------| 61:35.80 INFO | | TIMEOUT | | 61:35.80 INFO | `test <img sharedstoragewritable src=[url]> for same origin img` | TIMEOUT | `Test timed out` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-img-idl-attribute-included-bytes.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |------------------------------------------------------------------------------------------|---------|----------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `test <img sharedstoragewritable src=[url]> via JS for same origin img with bytestring` | PASS | | 61:35.80 INFO | `test <img sharedstoragewritable src=[url]> via JS for cross origin img with bytestring` | PASS | | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-img-idl-attribute-included.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |--------------------------------------------------------------------------|---------|----------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `test <img sharedstoragewritable src=[url]> via JS for same origin img` | PASS | | 61:35.80 INFO | `test <img sharedstoragewritable src=[url]> via JS for cross origin img` | PASS | | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-img-idl-attribute-not-included.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |----------------------------------------------------|---------|----------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `test <img src=[url]> via JS for same origin img` | PASS | | 61:35.80 INFO | `test <img src=[url]> via JS for cross origin img` | PASS | | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-multi-redirect.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------|----------------------------------------------------------------------------| 61:35.80 INFO | | TIMEOUT | | 61:35.80 INFO | `permissions policy header shared-storage=(self) allows the 'Shared-Storage-Writable' header to be sent for the redirect of a shared storage fetch request, where the redirect has a same-origin URL, even if an intermediate redirect has a cross-origin URL.` | FAIL | `assert_equals: expected "?1" but got "NO_SHARED_STORAGE_WRITABLE_HEADER"` | 61:35.80 INFO | `permissions policy header shared-storage=(self) allows the 'Shared-Storage-Writable' header to be sent for the redirect of a shared storage image request, where the redirect has a same-origin URL, even if an intermediate redirect has a cross-origin URL.` | TIMEOUT | `Test timed out` | 61:35.80 INFO | `permissions policy header shared-storage=(self) allows the 'Shared-Storage-Writable' header to be sent for the redirect of a shared storage iframe request, where the redirect has a same-origin URL, even if an intermediate redirect has a cross-origin URL.` | NOTRUN | | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-permissions-policy-default.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------|----------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `Default permissions policy allows the 'Sec-Shared-Storage-Writable' header to be sent for the same-origin shared storage fetch request.` | FAIL | `assert_equals: expected "?1" but got "NO_SHARED_STORAGE_WRITABLE_HEADER"` | 61:35.80 INFO | `Default permissions policy allows the 'Sec-Shared-Storage-Writable' header to be sent for the cross-origin shared storage fetch request.` | FAIL | `assert_equals: expected "?1" but got "NO_SHARED_STORAGE_WRITABLE_HEADER"` | 61:35.80 INFO | `Default permissions policy allows the 'Sec-Shared-Storage-Writable' header to be sent for the redirect of a shared storage fetch request, where the redirect has a same-origin URL.` | FAIL | `assert_equals: expected "?1" but got "NO_SHARED_STORAGE_WRITABLE_HEADER"` | 61:35.80 INFO | `Default permissions policy allows the 'Sec-Shared-Storage-Writable' header to be sent for the redirect of a shared storage fetch request, where the redirect has a cross-origin URL.` | FAIL | `assert_equals: expected "?1" but got "NO_SHARED_STORAGE_WRITABLE_HEADER"` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-permissions-policy-self.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------|----------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `permissions policy header shared-storage=(self) allows the 'Sec-Shared-Storage-Writable' header to be sent for the same-origin shared storage fetch request.` | FAIL | `assert_equals: expected "?1" but got "NO_SHARED_STORAGE_WRITABLE_HEADER"` | 61:35.80 INFO | `permissions policy header shared-storage=(self) disallows the 'Sec-Shared-Storage-Writable' header to be sent for the cross-origin shared storage fetch request.` | PASS | | 61:35.80 INFO | `permissions policy header shared-storage=(self) allows the 'Sec-Shared-Storage-Writable' header to be sent for the redirect of a shared storage fetch request, where the redirect has a same-origin URL.` | FAIL | `assert_equals: expected "?1" but got "NO_SHARED_STORAGE_WRITABLE_HEADER"` | 61:35.80 INFO | `permissions policy header shared-storage=(self) disallows the 'Sec-Shared-Storage-Writable' header to be sent for the redirect of a shared storage fetch request, where the redirect has a cross-origin URL.` | PASS | | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-service-worker-fetch.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |----------------------------------------------------------------------------------------------------|---------|------------------| 61:35.80 INFO | | ERROR | | 61:35.80 INFO | `test fetch(url, {sharedStorageWritable: true}) via JS from service worker for same origin fetch` | TIMEOUT | `Test timed out` | 61:35.80 INFO | `test fetch(url, {sharedStorageWritable: true}) via JS from service worker for cross origin fetch` | NOTRUN | | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-service-worker-iframe.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |----------------------------------------------------------------------------------------------------|---------|------------------| 61:35.80 INFO | | TIMEOUT | | 61:35.80 INFO | `test <iframe sharedstoragewritable src=[url]> via JS from service worker for same origin iframe` | TIMEOUT | `Test timed out` | 61:35.80 INFO | `test <iframe sharedstoragewritable src=[url]> via JS from service worker for cross origin iframe` | NOTRUN | | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-service-worker-img.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |----------------------------------------------------------------------------------------------|--------------------------------|------------------| 61:35.80 INFO | | **ERROR: 9/10, TIMEOUT: 1/10** | | 61:35.80 INFO | `test <img sharedstoragewritable src=[url]> via JS from service worker for same origin img` | TIMEOUT | `Test timed out` | 61:35.80 INFO | `test <img sharedstoragewritable src=[url]> via JS from service worker for cross origin img` | NOTRUN | | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/shared-storage-writable-setters.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |-------------------------------------------------------------------------------------------------------------------|---------|----------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `Writing to shared storage via the 'Shared-Storage-Write' header for a same-origin shared storage fetch request` | FAIL | `assert_equals: expected "?1" but got "NO_SHARED_STORAGE_WRITABLE_HEADER"` | 61:35.80 INFO | `Writing to shared storage via the 'Shared-Storage-Write' header for a cross-origin shared storage fetch request` | FAIL | `assert_equals: expected "?1" but got "NO_SHARED_STORAGE_WRITABLE_HEADER"` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage/verify-get-undefined.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |---------------------------------------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `verify-get-undefined-url-selection-operation selectURL() resolves to config` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO | `verify-get-undefined-url-selection-operation selectURL() resolves to urn:uuid` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage-selecturl-limit/run-url-selection-operation-limit-multiple-sites.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |-----------------------------------------------|---------|------------------| 61:35.80 INFO | | TIMEOUT | | 61:35.80 INFO | `selectURL() with overall per-pageload limit` | TIMEOUT | `Test timed out` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage-selecturl-limit/run-url-selection-operation-limit.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |--------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `selectURL() with per-origin per-pageload limit` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO 61:35.80 INFO ### /shared-storage-selecturl-limit/select-url-limit-multiple-worklets.tentative.https.sub.html ### 61:35.80 INFO | Subtest | Results | Messages | 61:35.80 INFO |-------------------------------------------------------------------------------|---------|-------------------------------------------------------------------------------------------------------| 61:35.80 INFO | | OK | | 61:35.80 INFO | `selectURL() called on multiple worklets, with per-origin per-pageload limit` | FAIL | `promise_test: Unhandled rejection with value: object "ReferenceError: sharedStorage is not defined"` | 61:35.80 INFO 61:35.80 INFO ## Unstable results ## 61:35.80 INFO | Test | Subtest | Results | Messages | 61:35.80 INFO |---------------------------------------------------------------------------------------|---------|--------------------------------|----------| 61:35.80 INFO | `/shared-storage/shared-storage-writable-service-worker-img.tentative.https.sub.html` | | **ERROR: 9/10, TIMEOUT: 1/10** | | 61:35.80 INFO 61:35.80 INFO ::: Running tests in a loop with restarts 10 times : FAIL 61:35.80 INFO ::: 61:35.80 ERROR ::: Test verification FAIL 61:35.80 INFO ::: [taskcluster 2024-02-14 03:47:46.242Z] === Task Finished === [taskcluster 2024-02-14 03:47:46.584Z] Unsuccessful task run with exit code: 1 completed in 3839.407 seconds |
|
Pinged the author to see if this is an existing flakiness. |
|
From the author: Why are any of the privacy sandbox WPTs even running in Firefox? I don't think they support any of our new APIs yet. @KyleJu @DanielRyanSmith Can you help admin merge this? |
KyleJu
approved these changes
Feb 15, 2024
marcoscaceres
pushed a commit
that referenced
this pull request
Feb 23, 2024
…4552) Navigations into and out of fenced frames need to be treated specially for network revocation, because they don't have the revoked partition nonce attached. Previous CLs disabled embedder-initiated fenced frame root navigations and _unfencedTop navigations; this CL disables popup navigations. Bug: 1515599 Change-Id: Ia05e3fecb40240de1d32a3e736e42eba5f03f411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5259509 Reviewed-by: Dominic Farolino <dom@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Garrett Tanzer <gtanzer@chromium.org> Cr-Commit-Position: refs/heads/main@{#1260187} Co-authored-by: Garrett Tanzer <gtanzer@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigations into and out of fenced frames need to be treated specially
for network revocation, because they don't have the revoked partition
nonce attached.
Previous CLs disabled embedder-initiated fenced frame root navigations
and _unfencedTop navigations; this CL disables popup navigations.
Bug: 1515599
Change-Id: Ia05e3fecb40240de1d32a3e736e42eba5f03f411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5259509
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Garrett Tanzer <gtanzer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1260187}