Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move monolithic-overflow-* from css/printing to css/css-page. #44422

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 6, 2024

Ideally, css/printing/ should be emptied. Here's a step in that
direction.

See #42937

I also just removed the failure expectations from
ChromeTestExpectations, since I couldn't find the reason why they were
added in the first place, and besides, all bots seem to be happy.

Change-Id: I4af6c637861e6ecbfa18b680deb9e82e0e7876f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272546
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257066}

Ideally, css/printing/ should be emptied. Here's a step in that
direction.

See #42937

I also just removed the failure expectations from
ChromeTestExpectations, since I couldn't find the reason why they were
added in the first place, and besides, all bots seem to be happy.

Change-Id: I4af6c637861e6ecbfa18b680deb9e82e0e7876f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272546
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257066}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@dev-ansung
Copy link
Contributor

Slow tests

Test Result Longest duration (ms) Timeout (ms)
/css/css-page/monolithic-overflow-020-print.html FAIL 8274 10000
/css/css-page/monolithic-overflow-024-print.html FAIL 8107 10000
/css/css-page/monolithic-overflow-025-print.html FAIL 9670 10000

@dev-ansung
Copy link
Contributor

Filed https://g-issues.chromium.org/issues/324298027
@KyleJu @DanielRyanSmith Could you please admin merge? Thanks

@DanielRyanSmith DanielRyanSmith merged commit 0f06b11 into master Feb 8, 2024
16 of 18 checks passed
@DanielRyanSmith DanielRyanSmith deleted the chromium-export-cl-5272546 branch February 8, 2024 03:55
mbrodesser-Igalia pushed a commit to mbrodesser-Igalia/wpt that referenced this pull request Feb 19, 2024
…atform-tests#44422)

Ideally, css/printing/ should be emptied. Here's a step in that
direction.

See web-platform-tests#42937

I also just removed the failure expectations from
ChromeTestExpectations, since I couldn't find the reason why they were
added in the first place, and besides, all bots seem to be happy.

Change-Id: I4af6c637861e6ecbfa18b680deb9e82e0e7876f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272546
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257066}

Co-authored-by: Morten Stenshorne <mstensho@chromium.org>
marcoscaceres pushed a commit that referenced this pull request Feb 23, 2024
Ideally, css/printing/ should be emptied. Here's a step in that
direction.

See #42937

I also just removed the failure expectations from
ChromeTestExpectations, since I couldn't find the reason why they were
added in the first place, and besides, all bots seem to be happy.

Change-Id: I4af6c637861e6ecbfa18b680deb9e82e0e7876f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272546
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257066}

Co-authored-by: Morten Stenshorne <mstensho@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants