-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move monolithic-overflow-* from css/printing to css/css-page. #44422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally, css/printing/ should be emptied. Here's a step in that direction. See #42937 I also just removed the failure expectations from ChromeTestExpectations, since I couldn't find the reason why they were added in the first place, and besides, all bots seem to be happy. Change-Id: I4af6c637861e6ecbfa18b680deb9e82e0e7876f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272546 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1257066}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5272546
branch
from
February 6, 2024 23:45
efe814c
to
b3db3ea
Compare
wpt-pr-bot
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
Slow tests
|
Filed https://g-issues.chromium.org/issues/324298027 |
mbrodesser-Igalia
pushed a commit
to mbrodesser-Igalia/wpt
that referenced
this pull request
Feb 19, 2024
…atform-tests#44422) Ideally, css/printing/ should be emptied. Here's a step in that direction. See web-platform-tests#42937 I also just removed the failure expectations from ChromeTestExpectations, since I couldn't find the reason why they were added in the first place, and besides, all bots seem to be happy. Change-Id: I4af6c637861e6ecbfa18b680deb9e82e0e7876f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272546 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1257066} Co-authored-by: Morten Stenshorne <mstensho@chromium.org>
marcoscaceres
pushed a commit
that referenced
this pull request
Feb 23, 2024
Ideally, css/printing/ should be emptied. Here's a step in that direction. See #42937 I also just removed the failure expectations from ChromeTestExpectations, since I couldn't find the reason why they were added in the first place, and besides, all bots seem to be happy. Change-Id: I4af6c637861e6ecbfa18b680deb9e82e0e7876f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272546 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1257066} Co-authored-by: Morten Stenshorne <mstensho@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, css/printing/ should be emptied. Here's a step in that
direction.
See #42937
I also just removed the failure expectations from
ChromeTestExpectations, since I couldn't find the reason why they were
added in the first place, and besides, all bots seem to be happy.
Change-Id: I4af6c637861e6ecbfa18b680deb9e82e0e7876f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5272546
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257066}