-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event Timing reports EventTarget for more pointer events #44372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
changed the title
Initial patch to add support for pointer target
Event Timing reports EventTarget for more pointer events
Feb 2, 2024
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5246848
branch
3 times, most recently
from
February 2, 2024 16:43
f8ac96e
to
d1cb6da
Compare
Only in cases where there is not a single pointer event registered on a page, blink may entirely optimize out EventDispatch steps, since there are no observers anyway. This optimization should not normally be detectable. However, the Event Timing API still measures these events and reports them to the performance timeline. Because the EventDispatch steps are where we assign EventTarget to Event objects, the Event Timing API was effectively missing the target value whenever we skipped this step. This patch plumbs the original HitTest target which we fall back to under such situations. Bug: 1367329 Change-Id: Icf21e6103c98261e9f6e88cef1ac09f3a683751b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5246848 Commit-Queue: Michal Mocny <mmocny@chromium.org> Reviewed-by: Aoyuan Zuo <zuoaoyuan@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255634}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5246848
branch
from
February 2, 2024 17:48
d1cb6da
to
2af947f
Compare
wpt-pr-bot
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
Unstable results
|
Filed https://crbug.com/1524539. |
mbrodesser-Igalia
pushed a commit
to mbrodesser-Igalia/wpt
that referenced
this pull request
Feb 19, 2024
…m-tests#44372) Only in cases where there is not a single pointer event registered on a page, blink may entirely optimize out EventDispatch steps, since there are no observers anyway. This optimization should not normally be detectable. However, the Event Timing API still measures these events and reports them to the performance timeline. Because the EventDispatch steps are where we assign EventTarget to Event objects, the Event Timing API was effectively missing the target value whenever we skipped this step. This patch plumbs the original HitTest target which we fall back to under such situations. Bug: 1367329 Change-Id: Icf21e6103c98261e9f6e88cef1ac09f3a683751b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5246848 Commit-Queue: Michal Mocny <mmocny@chromium.org> Reviewed-by: Aoyuan Zuo <zuoaoyuan@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255634} Co-authored-by: Michal Mocny <mmocny@chromium.org>
marcoscaceres
pushed a commit
that referenced
this pull request
Feb 23, 2024
Only in cases where there is not a single pointer event registered on a page, blink may entirely optimize out EventDispatch steps, since there are no observers anyway. This optimization should not normally be detectable. However, the Event Timing API still measures these events and reports them to the performance timeline. Because the EventDispatch steps are where we assign EventTarget to Event objects, the Event Timing API was effectively missing the target value whenever we skipped this step. This patch plumbs the original HitTest target which we fall back to under such situations. Bug: 1367329 Change-Id: Icf21e6103c98261e9f6e88cef1ac09f3a683751b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5246848 Commit-Queue: Michal Mocny <mmocny@chromium.org> Reviewed-by: Aoyuan Zuo <zuoaoyuan@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255634} Co-authored-by: Michal Mocny <mmocny@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only in cases where there is not a single pointer event registered on a page, blink may entirely optimize out EventDispatch steps, since there are no observers anyway. This optimization should not normally be detectable.
However, the Event Timing API still measures these events and reports them to the performance timeline. Because the EventDispatch steps are where we assign EventTarget to Event objects, the Event Timing API was effectively missing the target value whenever we skipped this step.
This patch plumbs the original HitTest target which we fall back to under such situations.
Bug: 1367329
Change-Id: Icf21e6103c98261e9f6e88cef1ac09f3a683751b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5246848
Commit-Queue: Michal Mocny <mmocny@chromium.org>
Reviewed-by: Aoyuan Zuo <zuoaoyuan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1255634}