[webnn] Add float32 tests for WebNN API l2Pool2d op #44314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thank you! |
fdwr
approved these changes
Feb 6, 2024
| { | ||
| "tests": [ | ||
| { | ||
| "name": "l2Pool2d float32 4D constant tensor all positive default options", |
There was a problem hiding this comment.
all positive
Since each element is squared anyway, it doesn't really matter for this case whether there's a mix of positive and negative value. I'm not suggesting you change anything, just noting.
There was a problem hiding this comment.
it doesn't really matter for this case whether there's a mix of positive and negative value
I remembered that you once share me the operation list of avoiding catastrophic cancellation which included this l2Pool2d .
| } | ||
| }, | ||
| { | ||
| "name": "l2Pool2d float32 4D tensor options.autoPad=same-lower ignores options.padding", |
There was a problem hiding this comment.
There was talk of removing automagic padding consistently for both convolution and pooling: webmachinelearning/webnn-baseline#68 (review)
I suppose we can keep these cases until a spec CR is proposed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fdwr @patrto and @Honry PTAL, thanks.