Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc wpt: update more tests to use receiver capabilities for setCodecPreferences #44554

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 13, 2024

BUG=webrtc:15396

Change-Id: Icb67eacc4554c5cf356b12ff7e7306ac795c4f34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5287360
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1259818}

…ecPreferences

BUG=webrtc:15396

Change-Id: Icb67eacc4554c5cf356b12ff7e7306ac795c4f34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5287360
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1259818}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@fippo
Copy link
Contributor

fippo commented Feb 13, 2024

https://github.com/web-platform-tests/wpt/pull/44554/checks?check_run_id=21525441527
affects /webrtc/RTCDTMFSender-ontonechange.https.html, /webrtc/RTCDTMFSender-ontonechange.https.html and /webrtc/RTCDataChannel-iceRestart.html neither of which is touched by this PR?

@WeizhongX
Copy link
Contributor

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results

Test | Subtest | Results | Messages -- | -- | -- | -- /webrtc/RTCDTMFSender-ontonechange.https.html | insertDTMF() with interToneGap less than 30 should be clamped to 30 | FAIL: 1/10, PASS: 9/10 | assert_between_inclusive: Expect tonechange event for "B" to be fired approximately after 130 milliseconds expected a number greater than or equal to 130 and less than or equal to 4130 but got 129 /webrtc/RTCDTMFSender-ontonechange.https.html | insertDTMF() with transceiver stopped in the middle should stop future tonechange events from firing | FAIL: 1/10, PASS: 9/10 | assert_between_inclusive: Expect tonechange event for "B" to be fired approximately after 170 milliseconds expected a number greater than or equal to 170 and less than or equal to 4170 but got 169 /webrtc/RTCDataChannel-iceRestart.html |   | ERROR: 9/10, OK: 1/10

harset='utf-8'>

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results


TestSubtestResultsMessages
/webrtc/RTCDTMFSender-ontonechange.https.htmlinsertDTMF() with interToneGap less than 30 should be clamped to 30FAIL: 1/10, PASS: 9/10assert_between_inclusive: Expect tonechange event for "B" to be fired approximately after 130 milliseconds expected a number greater than or equal to 130 and less than or equal to 4130 but got 129
/webrtc/RTCDTMFSender-ontonechange.https.htmlinsertDTMF() with transceiver stopped in the middle should stop future tonechange events from firingFAIL: 1/10, PASS: 9/10assert_between_inclusive: Expect tonechange event for "B" to be fired approximately after 170 milliseconds expected a number greater than or equal to 170 and less than or equal to 4170 but got 169
/webrtc/RTCDataChannel-iceRestart.htmlERROR: 9/10, OK: 1/10

@WeizhongX
Copy link
Contributor

Created bug https://buganizer.corp.google.com/issues/325081900

@KyleJu @DanielRyanSmith pls help admin merge, thanks!

@KyleJu KyleJu merged commit f664d06 into master Feb 13, 2024
16 of 18 checks passed
@KyleJu KyleJu deleted the chromium-export-cl-5287360 branch February 13, 2024 19:51
marcoscaceres pushed a commit that referenced this pull request Feb 23, 2024
…ecPreferences (#44554)

BUG=webrtc:15396

Change-Id: Icb67eacc4554c5cf356b12ff7e7306ac795c4f34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5287360
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1259818}

Co-authored-by: Philipp Hancke <phancke@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants