-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webrtc wpt: update more tests to use receiver capabilities for setCodecPreferences #44554
Conversation
…ecPreferences BUG=webrtc:15396 Change-Id: Icb67eacc4554c5cf356b12ff7e7306ac795c4f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5287360 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1259818}
39ed5fa
to
3e83d77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
https://github.com/web-platform-tests/wpt/pull/44554/checks?check_run_id=21525441527 |
WPT Command: Some affected tests had inconsistent (flaky) results: Unstable resultsTest | Subtest | Results | Messages -- | -- | -- | -- /webrtc/RTCDTMFSender-ontonechange.https.html | insertDTMF() with interToneGap less than 30 should be clamped to 30 | FAIL: 1/10, PASS: 9/10 | assert_between_inclusive: Expect tonechange event for "B" to be fired approximately after 130 milliseconds expected a number greater than or equal to 130 and less than or equal to 4130 but got 129 /webrtc/RTCDTMFSender-ontonechange.https.html | insertDTMF() with transceiver stopped in the middle should stop future tonechange events from firing | FAIL: 1/10, PASS: 9/10 | assert_between_inclusive: Expect tonechange event for "B" to be fired approximately after 170 milliseconds expected a number greater than or equal to 170 and less than or equal to 4170 but got 169 /webrtc/RTCDataChannel-iceRestart.html | | ERROR: 9/10, OK: 1/10harset='utf-8'> WPT Command: Some affected tests had inconsistent (flaky) results: Unstable results
|
Created bug https://buganizer.corp.google.com/issues/325081900 @KyleJu @DanielRyanSmith pls help admin merge, thanks! |
…ecPreferences (#44554) BUG=webrtc:15396 Change-Id: Icb67eacc4554c5cf356b12ff7e7306ac795c4f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5287360 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1259818} Co-authored-by: Philipp Hancke <phancke@microsoft.com>
BUG=webrtc:15396
Change-Id: Icb67eacc4554c5cf356b12ff7e7306ac795c4f34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5287360
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1259818}