Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "webnn: Remove sync methods" #44626

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 16, 2024

This is a reland of commit a3e84dde09e099bebbe4793ffaa70679168130d6

This CL contains a few additional changes:

  • Enables the async APIs on workers, which was causing bots to fail
    since workers could not call createContext()
  • Rebaselines WPTs accordingly
  • Updates the WPT expectations for the webnn-service-enabled virtual
    test suite

Original change's description:

webnn: Remove sync methods

See webmachinelearning/webnn#548

Deletes all sync methods and simplifies the names of all "Async"
methods - e.g. BuildAsync() -> Build()

Bug: 40283536, 41481333
Change-Id: I3b38d987cb4641ea41ab9a974c46dcba16d5c108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5292884
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1261223}

Cq-Include-Trybots: luci.chromium.try:win11-x64-fyi-rel
Bug: 40283536, 41481333, 41485898
Change-Id: Iffcb922b8175a7181deba1f4c2faa953010ae5c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5303774
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1262043}

This is a reland of commit a3e84dde09e099bebbe4793ffaa70679168130d6

This CL contains a few additional changes:
- Enables the async APIs on workers, which was causing bots to fail
  since workers could not call createContext()
- Rebaselines WPTs accordingly
- Updates the WPT expectations for the webnn-service-enabled virtual
  test suite

Original change's description:
> webnn: Remove sync methods
>
> See webmachinelearning/webnn#548
>
> Deletes all sync methods and simplifies the names of all "Async"
> methods - e.g. BuildAsync() -> Build()
>
> Bug: 40283536, 41481333
> Change-Id: I3b38d987cb4641ea41ab9a974c46dcba16d5c108
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5292884
> Commit-Queue: Austin Sullivan <asully@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: ningxin hu <ningxin.hu@intel.com>
> Reviewed-by: Alex Gough <ajgo@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1261223}

Cq-Include-Trybots: luci.chromium.try:win11-x64-fyi-rel
Bug: 40283536, 41481333, 41485898
Change-Id: Iffcb922b8175a7181deba1f4c2faa953010ae5c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5303774
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1262043}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@WeizhongX
Copy link
Contributor

79:44.65 INFO Ran 1 of 10 iterations.
79:44.65 wptserve INFO Stopped http server on 127.0.0.1:8000
79:44.65 wptserve INFO Stopped WebTransport over HTTP/3 server on 127.0.0.1:11000
79:44.73 wptserve INFO Stopped http server on 127.0.0.1:8443
79:45.05 wptserve INFO Close on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 8888))
79:45.05 wptserve INFO Stopped http server on 127.0.0.1:8001
79:45.05 wptserve INFO Stopped http server on 127.0.0.1:8002
79:45.05 wptserve INFO Stopped http server on 127.0.0.1:8445
79:45.05 wptserve INFO Stopped http server on 127.0.0.1:8444
79:45.05 wptserve INFO Stopped http server on 127.0.0.1:9000
79:45.05 wptserve INFO Stopped http server on 127.0.0.1:8003
79:45.05 wptserve INFO Close on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 8889))
79:45.05 wptserve INFO Stopped http server on 127.0.0.1:8446
79:45.19 INFO Removed font: Ahem.ttf
79:45.23 INFO Closing logging queue
79:45.23 INFO queue closed
79:45.29 INFO ::: Ran 1 of expected 10 iterations.
79:45.29 INFO ::: Reached iteration timeout before finishing 2 or more repeat runs.
79:45.29 INFO ::: At least 2 successful repeat runs are required to validate stability.
79:45.29 INFO ::: Running tests in a loop with restarts 10 times : FAIL
79:45.29 INFO :::
79:45.29 WARNING ::: Test verification TIMEOUT

@WeizhongX
Copy link
Contributor

@KyleJu @jcscottiii The log says "Test verification TIMEOUT". Can you pls take a look?

@KyleJu KyleJu merged commit 0e308a6 into master Feb 20, 2024
12 of 16 checks passed
@KyleJu KyleJu deleted the chromium-export-cl-5303774 branch February 20, 2024 19:08
marcoscaceres pushed a commit that referenced this pull request Feb 23, 2024
This is a reland of commit a3e84dde09e099bebbe4793ffaa70679168130d6

This CL contains a few additional changes:
- Enables the async APIs on workers, which was causing bots to fail
  since workers could not call createContext()
- Rebaselines WPTs accordingly
- Updates the WPT expectations for the webnn-service-enabled virtual
  test suite

Original change's description:
> webnn: Remove sync methods
>
> See webmachinelearning/webnn#548
>
> Deletes all sync methods and simplifies the names of all "Async"
> methods - e.g. BuildAsync() -> Build()
>
> Bug: 40283536, 41481333
> Change-Id: I3b38d987cb4641ea41ab9a974c46dcba16d5c108
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5292884
> Commit-Queue: Austin Sullivan <asully@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: ningxin hu <ningxin.hu@intel.com>
> Reviewed-by: Alex Gough <ajgo@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1261223}

Cq-Include-Trybots: luci.chromium.try:win11-x64-fyi-rel
Bug: 40283536, 41481333, 41485898
Change-Id: Iffcb922b8175a7181deba1f4c2faa953010ae5c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5303774
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1262043}

Co-authored-by: Austin Sullivan <asully@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants