-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reland "webnn: Remove sync methods" #44626
Conversation
0b3093c
to
b0553cc
Compare
This is a reland of commit a3e84dde09e099bebbe4793ffaa70679168130d6 This CL contains a few additional changes: - Enables the async APIs on workers, which was causing bots to fail since workers could not call createContext() - Rebaselines WPTs accordingly - Updates the WPT expectations for the webnn-service-enabled virtual test suite Original change's description: > webnn: Remove sync methods > > See webmachinelearning/webnn#548 > > Deletes all sync methods and simplifies the names of all "Async" > methods - e.g. BuildAsync() -> Build() > > Bug: 40283536, 41481333 > Change-Id: I3b38d987cb4641ea41ab9a974c46dcba16d5c108 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5292884 > Commit-Queue: Austin Sullivan <asully@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: ningxin hu <ningxin.hu@intel.com> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1261223} Cq-Include-Trybots: luci.chromium.try:win11-x64-fyi-rel Bug: 40283536, 41481333, 41485898 Change-Id: Iffcb922b8175a7181deba1f4c2faa953010ae5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5303774 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262043}
b0553cc
to
5a24b3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
79:44.65 INFO Ran 1 of 10 iterations. |
@KyleJu @jcscottiii The log says "Test verification TIMEOUT". Can you pls take a look? |
This is a reland of commit a3e84dde09e099bebbe4793ffaa70679168130d6 This CL contains a few additional changes: - Enables the async APIs on workers, which was causing bots to fail since workers could not call createContext() - Rebaselines WPTs accordingly - Updates the WPT expectations for the webnn-service-enabled virtual test suite Original change's description: > webnn: Remove sync methods > > See webmachinelearning/webnn#548 > > Deletes all sync methods and simplifies the names of all "Async" > methods - e.g. BuildAsync() -> Build() > > Bug: 40283536, 41481333 > Change-Id: I3b38d987cb4641ea41ab9a974c46dcba16d5c108 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5292884 > Commit-Queue: Austin Sullivan <asully@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: ningxin hu <ningxin.hu@intel.com> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1261223} Cq-Include-Trybots: luci.chromium.try:win11-x64-fyi-rel Bug: 40283536, 41481333, 41485898 Change-Id: Iffcb922b8175a7181deba1f4c2faa953010ae5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5303774 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262043} Co-authored-by: Austin Sullivan <asully@chromium.org>
This is a reland of commit a3e84dde09e099bebbe4793ffaa70679168130d6
This CL contains a few additional changes:
since workers could not call createContext()
test suite
Original change's description:
Cq-Include-Trybots: luci.chromium.try:win11-x64-fyi-rel
Bug: 40283536, 41481333, 41485898
Change-Id: Iffcb922b8175a7181deba1f4c2faa953010ae5c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5303774
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1262043}