Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WPTs for race-network-and-fetch-handler option #44345

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 1, 2024

Adds tests for race-network-and-fetch-handler, which is the service
worker static routing API's router source option.

This tests check the case when the network request wins and the fetch
handler wins the race respectively, both for the main resource and
subresource.

Bug: 1519727
Change-Id: I19fe304c294f64d99d08c76be113a41d726b8d52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5256919
Commit-Queue: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1255046}

Adds tests for `race-network-and-fetch-handler`, which is the service
worker static routing API's router source option.

This tests check the case when the network request wins and the fetch
handler wins the race respectively, both for the main resource and
subresource.

Bug: 1519727
Change-Id: I19fe304c294f64d99d08c76be113a41d726b8d52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5256919
Commit-Queue: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1255046}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@dev-ansung
Copy link
Contributor

Unstable results

Test Subtest Results Messages
/service-workers/service-worker/tentative/static-router/static-router-race-network-and-fetch-handler.https.html   OK: 9/10, TIMEOUT: 1/10  
/service-workers/service-worker/tentative/static-router/static-router-race-network-and-fetch-handler.https.html Main resource load matched the rule with race-network-and-fetch-handler source, and the server reseponse is faster than the fetch handler FAIL: 9/10, TIMEOUT: 1/10 assert_unreached: unregister and register should not fail: ServiceWorker script at https://web-platform.test:8443/service-workers/service-worker/tentative/static-router/resources/static-router-race-network-and-fetch-handler-sw.js?key=condition-urlpattern-string-source-race-network-and-fetch-handler for scope https://web-platform.test:8443/service-workers/service-worker/tentative/static-router/resources/ threw an exception during script evaluation. Reached unreachable code;Test timed out
/service-workers/service-worker/tentative/static-router/static-router-race-network-and-fetch-handler.https.html Subresource load matched the rule with race-network-and-fetch-handler source, and the fetch handler response is faster than the server response FAIL: 9/10, NOTRUN: 1/10 assert_unreached: unregister and register should not fail: ServiceWorker script at https://web-platform.test:8443/service-workers/service-worker/tentative/static-router/resources/static-router-race-network-and-fetch-handler-sw.js?key=condition-urlpattern-string-source-race-network-and-fetch-handler for scope https://web-platform.test:8443/service-workers/service-worker/tentative/static-router/resources/ threw an exception during script evaluation. Reached unreachable code
/service-workers/service-worker/tentative/static-router/static-router-race-network-and-fetch-handler.https.html Subresource load matched the rule with race-network-and-fetch-handler source, and the server reseponse is faster than the fetch handler FAIL: 9/10, NOTRUN: 1/10 assert_unreached: unregister and register should not fail: ServiceWorker script at https://web-platform.test:8443/service-workers/service-worker/tentative/static-router/resources/static-router-race-network-and-fetch-handler-sw.js?key=condition-urlpattern-string-source-race-network-and-fetch-handler for scope https://web-platform.test:8443/service-workers/service-worker/tentative/static-router/resources/ threw an exception during script evaluation. Reached unreachable code

@dev-ansung
Copy link
Contributor

Filed https://crbug.com/1524538.
@KyleJu @DanielRyanSmith Could you please admin merge? Thanks

@DanielRyanSmith DanielRyanSmith merged commit 33a65d0 into master Feb 3, 2024
15 of 18 checks passed
@DanielRyanSmith DanielRyanSmith deleted the chromium-export-cl-5256919 branch February 3, 2024 04:26
mbrodesser-Igalia pushed a commit to mbrodesser-Igalia/wpt that referenced this pull request Feb 19, 2024
…s#44345)

Adds tests for `race-network-and-fetch-handler`, which is the service
worker static routing API's router source option.

This tests check the case when the network request wins and the fetch
handler wins the race respectively, both for the main resource and
subresource.

Bug: 1519727
Change-Id: I19fe304c294f64d99d08c76be113a41d726b8d52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5256919
Commit-Queue: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1255046}

Co-authored-by: sisidovski <sisidovski@chromium.org>
marcoscaceres pushed a commit that referenced this pull request Feb 23, 2024
Adds tests for `race-network-and-fetch-handler`, which is the service
worker static routing API's router source option.

This tests check the case when the network request wins and the fetch
handler wins the race respectively, both for the main resource and
subresource.

Bug: 1519727
Change-Id: I19fe304c294f64d99d08c76be113a41d726b8d52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5256919
Commit-Queue: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1255046}

Co-authored-by: sisidovski <sisidovski@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants