-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WPTs for race-network-and-fetch-handler option #44345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests for `race-network-and-fetch-handler`, which is the service worker static routing API's router source option. This tests check the case when the network request wins and the fetch handler wins the race respectively, both for the main resource and subresource. Bug: 1519727 Change-Id: I19fe304c294f64d99d08c76be113a41d726b8d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5256919 Commit-Queue: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255046}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5256919
branch
from
February 1, 2024 15:33
034617b
to
bd1b6b5
Compare
wpt-pr-bot
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
Unstable results
|
Filed https://crbug.com/1524538. |
mbrodesser-Igalia
pushed a commit
to mbrodesser-Igalia/wpt
that referenced
this pull request
Feb 19, 2024
…s#44345) Adds tests for `race-network-and-fetch-handler`, which is the service worker static routing API's router source option. This tests check the case when the network request wins and the fetch handler wins the race respectively, both for the main resource and subresource. Bug: 1519727 Change-Id: I19fe304c294f64d99d08c76be113a41d726b8d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5256919 Commit-Queue: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255046} Co-authored-by: sisidovski <sisidovski@chromium.org>
marcoscaceres
pushed a commit
that referenced
this pull request
Feb 23, 2024
Adds tests for `race-network-and-fetch-handler`, which is the service worker static routing API's router source option. This tests check the case when the network request wins and the fetch handler wins the race respectively, both for the main resource and subresource. Bug: 1519727 Change-Id: I19fe304c294f64d99d08c76be113a41d726b8d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5256919 Commit-Queue: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255046} Co-authored-by: sisidovski <sisidovski@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for
race-network-and-fetch-handler
, which is the serviceworker static routing API's router source option.
This tests check the case when the network request wins and the fetch
handler wins the race respectively, both for the main resource and
subresource.
Bug: 1519727
Change-Id: I19fe304c294f64d99d08c76be113a41d726b8d52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5256919
Commit-Queue: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1255046}