-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL: file and non-special URL setters #4696
Conversation
Notifying @Sebmaster, @domenic, @mikewest, @rubys, @sideshowbarker, @smola, @tomalec, @xiaojunwu, and @zcorpan. (Learn how reviewing works.) These tests will be available shortly on w3c-test.org. w3c-test:do-not-mirror (What's this?) |
Chrome (unstable channel)Testing web-platform-tests at revision 37e78cf All results/url/url-constructor.html
/url/url-setters.html
/url/url-origin.html
/url/a-element-xhtml.xhtml
/url/a-element.html
/url/a-element-origin.html
/url/a-element-origin-xhtml.xhtml
|
whatwg-url PR: jsdom/whatwg-url#71 All the new tests appear to pass, but a bunch of old ones have become invalidated, for the host and hostname setters. I'll only list host since hostname is analogous. As usual, "expected" = new WPTs, "actual" = jsdom/whatwg-url with the spec patch applied.
|
Also file URL host parsing. See whatwg/url#224 for the corresponding URL Standard change.
512b95e
to
04b0796
Compare
It turns out those are still valid. I found a small glitch in your jsdom/whatwg-url code. |
This change depends on whatwg/url#224 landing first. Tests: web-platform-tests/wpt#4696. Location API bits are not tested since we generally treat loading from file URLs as out-of-scope of the web platform, but accounting for it standards-wise seemed trivial enough.
Dang, I'm really losing my touch. |
I'll wait with landing these until the changes in URL and HTML are also reviewed. Would be nice to keep everything synchronized somewhat. |
This change builds on whatwg/url#224. Tests: web-platform-tests/wpt#4696. Location API bits are not tested since we generally treat loading from file URLs as out-of-scope for the web platform, but accounting for it standards-wise seemed trivial enough.
This change builds on whatwg/url#224. Tests: web-platform-tests/wpt#4696. Location API bits are not tested since we generally treat loading from file URLs as out-of-scope for the web platform, but accounting for it standards-wise seemed trivial enough.
Also file URL host parsing.
See whatwg/url#224 for the corresponding URL Standard change.