Align with URL API changes for file and non-special URLs #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change depends on whatwg/url#224 landing first. Tests: web-platform-tests/wpt#4696. Location API bits are not tested since we generally treat loading from file URLs as out-of-scope of the web platform, but accounting for it standards-wise seemed trivial enough.
domenic
approved these changes
Feb 3, 2017
There was a problem hiding this comment.
LGTM but see whatwg/url#224 (comment).
Marking "do not merge yet" until the URL spec change lands.
domenic
added
the
do not merge yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change depends on whatwg/url#224 landing
first.
Tests: web-platform-tests/wpt#4696.
Location API bits are not tested since we generally treat loading from
file URLs as out-of-scope of the web platform, but accounting for it
standards-wise seemed trivial enough.