Rename & refactor invoker commands to reflect new spec decisions. #48581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invoker commands now live solely on HTMLButtonElement, and have been dropped from HTMLInputElement. This was discussed and resolved + minuted in Jul 18 WHATNOT meeting: whatwg/html#10471 (comment)) Words must be separated with dashes. This was discussed and resolved + minuted in Jul 18 WHATNOT meeting: whatwg/html#10471 (comment)) "Custom" commands now require a double dash (`--`) prefix. This was discussed & resolved + minuted in the Jul 25 OpenUI meeting: openui/open-ui#969 (comment) In addition, CommandEvent#invoker is now renamed to CommandEvent#source as discussed and resolved + minuted in Jul 18 WHATNOT meeting: whatwg/html#10471 (comment)) This CL updates the tests & implementation to follow these changes. The changes can also be found in the spec PR which reflects this updated status: whatwg/html#9841 Bug: 40284894 Change-Id: Iefa91a1736867239a21f8717aee1fcaaa54fdfd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839601 Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Luke <lwarlow@igalia.com> Commit-Queue: Keith Cirkel <chromium@keithcirkel.co.uk> Cr-Commit-Position: refs/heads/main@{#1367705}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5839601
branch
from
0608e05
to
89a5856
Compare
wpt-pr-bot
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoker commands now live solely on HTMLButtonElement, and have been
dropped from HTMLInputElement. This was discussed and resolved + minuted
in Jul 18 WHATNOT meeting:
whatwg/html#10471 (comment))
Words must be separated with dashes. This was discussed and resolved +
minuted in Jul 18 WHATNOT meeting:
whatwg/html#10471 (comment))
"Custom" commands now require a double dash (
--) prefix. This wasdiscussed & resolved + minuted in the Jul 25 OpenUI meeting:
openui/open-ui#969 (comment)
In addition, CommandEvent#invoker is now renamed to CommandEvent#source
as discussed and resolved + minuted in Jul 18 WHATNOT meeting:
whatwg/html#10471 (comment))
This CL updates the tests & implementation to follow these changes. The
changes can also be found in the spec PR which reflects this updated
status:
whatwg/html#9841
Bug: 40284894
Change-Id: Iefa91a1736867239a21f8717aee1fcaaa54fdfd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839601
Reviewed-by: Mason Freed <masonf@chromium.org>
Reviewed-by: Luke <lwarlow@igalia.com>
Commit-Queue: Keith Cirkel <chromium@keithcirkel.co.uk>
Cr-Commit-Position: refs/heads/main@{#1367705}