Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename & refactor invoker commands to reflect new spec decisions. #48581

Merged
merged 1 commit into from
Oct 11, 2024

Commits on Oct 11, 2024

  1. Rename & refactor invoker commands to reflect new spec decisions.

    Invoker commands now live solely on HTMLButtonElement, and have been
    dropped from HTMLInputElement. This was discussed and resolved + minuted
    in Jul 18 WHATNOT meeting:
    whatwg/html#10471 (comment))
    
    Words must be separated with dashes. This was discussed and resolved +
    minuted in Jul 18 WHATNOT meeting:
    whatwg/html#10471 (comment))
    
    "Custom" commands now require a double dash (`--`) prefix. This was
    discussed & resolved + minuted in the Jul 25 OpenUI meeting:
    openui/open-ui#969 (comment)
    
    In addition, CommandEvent#invoker is now renamed to CommandEvent#source
    as discussed and resolved + minuted in Jul 18 WHATNOT meeting:
    whatwg/html#10471 (comment))
    
    This CL updates the tests & implementation to follow these changes. The
    changes can also be found in the spec PR which reflects this updated
    status:
    
    whatwg/html#9841
    
    Bug: 40284894
    Change-Id: Iefa91a1736867239a21f8717aee1fcaaa54fdfd0
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839601
    Reviewed-by: Mason Freed <masonf@chromium.org>
    Reviewed-by: Luke <lwarlow@igalia.com>
    Commit-Queue: Keith Cirkel <chromium@keithcirkel.co.uk>
    Cr-Commit-Position: refs/heads/main@{#1367705}
    keithamus authored and chromium-wpt-export-bot committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    89a5856 View commit details
    Browse the repository at this point in the history