Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get r,s,v values from a signature #2139

Closed
wants to merge 17 commits into from

Conversation

aalok05
Copy link

@aalok05 aalok05 commented Dec 19, 2018

Description

Added a getSignatureParameters utility method to get r,s,v values from an ECDSA signature. Addressing #2047 . Please let me know if any changes are required. Thanks!

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
    (I've made changes to the web3-utils.rst file only)
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test with success and extended the tests if necessary.
  • I ran npm run build and tested the resulting file from dist folder in a browser.
  • I have tested my code on the live network.

@aalok05
Copy link
Author

aalok05 commented Dec 19, 2018

Hey @nivida , lerna bootstrap is failing in CI. Please help.

@nivida
Copy link
Contributor

nivida commented Dec 19, 2018

@aalok05 Hay the ethereumProvider branch is heavily under development that's why the CI is failing. Currently, we can just ignore it. I will fix the CI and extend it right before I will merge the PR 2000.

@aalok05
Copy link
Author

aalok05 commented Dec 19, 2018

Great! Thanks.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.993% when pulling fc8496a on aalok05:ethereumProvider into 8047e63 on ethereum:ethereumProvider.

@coveralls
Copy link

coveralls commented Jan 10, 2019

Coverage Status

Coverage increased (+0.1%) to 93.251% when pulling 3828f06 on aalok05:ethereumProvider into 1ba3669 on ethereum:ethereumProvider.

@nivida
Copy link
Contributor

nivida commented Jan 21, 2019

I'm closing this PR because I merged the other PR (#2178)

@nivida nivida closed this Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants