Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing exports #2178

Merged
merged 17 commits into from
Jan 21, 2019
Merged

Add missing exports #2178

merged 17 commits into from
Jan 21, 2019

Conversation

aalok05
Copy link

@aalok05 aalok05 commented Jan 10, 2019

Description

Fixed a bunch of incorrect/missing imports/exports which were breaking tests.

Type of change

  • Added fixes for tests

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test with success and extended the tests if necessary.
  • I ran npm run build and tested the resulting file from dist folder in a browser.
  • I have tested my code on the live network.

@aalok05 aalok05 mentioned this pull request Jan 10, 2019
9 tasks
@coveralls
Copy link

coveralls commented Jan 10, 2019

Coverage Status

Coverage increased (+0.1%) to 93.251% when pulling 046c556 on aalok05:addMissingExports into 1ba3669 on ethereum:ethereumProvider.

@nivida nivida added the Enhancement Includes improvements or optimizations label Jan 18, 2019
@nivida
Copy link
Contributor

nivida commented Jan 18, 2019

Will merge it later into the ethereumProvider branch. Thanks for your efforts!

@nivida nivida merged commit 0610c89 into web3:ethereumProvider Jan 21, 2019
@nivida nivida mentioned this pull request Jan 21, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants