Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests #2177

Closed
wants to merge 18 commits into from
Closed

Conversation

aalok05
Copy link

@aalok05 aalok05 commented Jan 10, 2019

Description

Fixed a bunch of incorrect/missing imports/exports which were breaking tests.

Type of change

  • Added fixes for tests

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test with success and extended the tests if necessary.
  • I ran npm run build and tested the resulting file from dist folder in a browser.
  • I have tested my code on the live network.

@aalok05
Copy link
Author

aalok05 commented Jan 10, 2019

Closing this for now. Will create a new one.
See #2178

@aalok05 aalok05 closed this Jan 10, 2019
@aalok05 aalok05 deleted the fixBrokenTests branch January 10, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant