Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not required @types/bignumber.js removed from package.json in web3-core #3213

Merged
merged 2 commits into from
Nov 19, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Nov 15, 2019

Description

Fixes #3209

Type of change

  • Dependencies

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test with success and extended the tests if necessary.
  • I ran npm run build and tested the resulting file from dist folder in a browser.
  • I have tested my code on the live network.

@nivida nivida added dependencies 1.x 1.0 related issues labels Nov 15, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.347% when pulling acbb039 on issue/3209 into e252b8c on 1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web3-core > @types/bignumber.js@5.0.0 — dependency is apparently not needed
2 participants