-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eth_createAccessList - Closes #4081 #4332
Conversation
Your Render PR Server URL is https://web3-js-pr-4332.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c51fn4s6fj3626qo74r0. |
Docs for this method were added here, but the PR was reverted. The subsequent PR to add back the docs was closed, and there doesn't seem to be anything adding it to the mentioned repo So I'm operating under the assumption that |
I've tested that this works as expected using this repo Access list generated by these changes: {
"accessList": [
{
"address": "0x35288259dc7fd6a6986cb3827965a4b711f73d81",
"storageKeys": [
"0x0000000000000000000000000000000000000000000000000000000000000002",
"0x405787fa12a823e0f2b7631cc41b3ba8828b3321ca811111fa75cd3aa3bb5ad0",
"0x405787fa12a823e0f2b7631cc41b3ba8828b3321ca811111fa75cd3aa3bb5ad1"
]
}
],
"gasUsed": "0x76ee"
} Access list by submitting the same transaction directly to Geth: {
"jsonrpc": "2.0",
"id": 1,
"result": {
"accessList": [
{
"address": "0x35288259dc7fd6a6986cb3827965a4b711f73d81",
"storageKeys": [
"0x0000000000000000000000000000000000000000000000000000000000000002",
"0x405787fa12a823e0f2b7631cc41b3ba8828b3321ca811111fa75cd3aa3bb5ad0",
"0x405787fa12a823e0f2b7631cc41b3ba8828b3321ca811111fa75cd3aa3bb5ad1"
]
}
],
"gasUsed": "0x76ee"
}
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the feedback of @jdevcs LGTM.
Ok |
createAccessList
toweb3.eth
(web3.eth.createAccessList
)createAccessList
to contract method wrapperscontract.methods.myMethod(some, parameters).createAccessList({ from: '0x0...' })
I believe only Geth supports
eth_createAccessList
right now, but I'm not sureCloses #4081