-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add createAccessList type #5146
Merged
jdevcs
merged 5 commits into
web3:junaid/createaccesslisttypes
from
0xall:createAccessList
Jul 5, 2022
Merged
Add createAccessList type #5146
jdevcs
merged 5 commits into
web3:junaid/createaccesslisttypes
from
0xall:createAccessList
Jul 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi there, thank you so much for your submission and the details for it :) Can you add this change to the changelog.md and make it under |
luu-alex
assigned nazarhussain, avkos and jdevcs and unassigned nazarhussain, avkos and jdevcs
Jun 17, 2022
luu-alex
requested review from
luu-alex,
avkos,
jdevcs,
nazarhussain and
spacesailor24
June 17, 2022 20:29
luu-alex
added
1.x
1.0 related issues
Changes Requested
Requires further changes
Enhancement
Includes improvements or optimizations
labels
Jun 17, 2022
Pull Request Test Coverage Report for Build 2542220090
💛 - Coveralls |
Thanks :) I updated CHANGELOG.md |
nazarhussain
approved these changes
Jun 20, 2022
luu-alex
approved these changes
Jun 20, 2022
I resolved conflicts. |
nazarhussain
added
Future Release
For future release.
and removed
Changes Requested
Requires further changes
labels
Jun 22, 2022
jdevcs
approved these changes
Jun 23, 2022
avkos
approved these changes
Jun 27, 2022
16 tasks
jdevcs
added a commit
that referenced
this pull request
Jul 5, 2022
* Add createAccessList type (#5146) * add createAccessList method type in web3.eth * add optional error field in CreateAccessList result type * update CHANGELOG.md Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com> Co-authored-by: Allen K <ksw3894@gmail.com>
Merged via #5204 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1.x
1.0 related issues
Enhancement
Includes improvements or optimizations
Future Release
For future release.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AccessTuple
type : https://github.com/ethereum/go-ethereum/blob/master/core/types/access_list_tx.go#L31createAccessList
param is same withestimateGas
estimateGas : https://github.com/ethereum/go-ethereum/blob/master/internal/ethapi/api.go#L1151
createAccessList : https://github.com/ethereum/go-ethereum/blob/master/internal/ethapi/api.go#L1367
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.