Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add createAccessList type #5146

Merged
merged 5 commits into from
Jul 5, 2022

Conversation

0xall
Copy link

@0xall 0xall commented Jun 17, 2022

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@0xall 0xall changed the title Create access list Add createAccessList type Jun 17, 2022
@luu-alex
Copy link
Contributor

Hi there, thank you so much for your submission and the details for it :) Can you add this change to the changelog.md and make it under 1.7.5.

@luu-alex luu-alex added 1.x 1.0 related issues Changes Requested Requires further changes Enhancement Includes improvements or optimizations labels Jun 17, 2022
@coveralls
Copy link

coveralls commented Jun 17, 2022

Pull Request Test Coverage Report for Build 2542220090

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.174%

Totals Coverage Status
Change from base Build 2536784248: 0.0%
Covered Lines: 3382
Relevant Lines: 4415

💛 - Coveralls

@0xall
Copy link
Author

0xall commented Jun 18, 2022

Thanks :) I updated CHANGELOG.md

@0xall
Copy link
Author

0xall commented Jun 22, 2022

I resolved conflicts.

@nazarhussain nazarhussain added Future Release For future release. and removed Changes Requested Requires further changes labels Jun 22, 2022
@jdevcs jdevcs changed the base branch from 1.x to junaid/createaccesslisttypes July 5, 2022 11:24
@jdevcs jdevcs merged commit cdb4dc9 into web3:junaid/createaccesslisttypes Jul 5, 2022
@jdevcs jdevcs mentioned this pull request Jul 5, 2022
16 tasks
jdevcs added a commit that referenced this pull request Jul 5, 2022
* Add createAccessList type (#5146)

* add createAccessList method type in web3.eth

* add optional error field in CreateAccessList result type

* update CHANGELOG.md

Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>

Co-authored-by: Allen K <ksw3894@gmail.com>
@jdevcs
Copy link
Contributor

jdevcs commented Jul 5, 2022

Merged via #5204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations Future Release For future release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants