-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added comaparison for package size #6852
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6852 +/- ##
==========================================
+ Coverage 87.37% 92.06% +4.68%
==========================================
Files 197 215 +18
Lines 7548 8212 +664
Branches 2059 2208 +149
==========================================
+ Hits 6595 7560 +965
+ Misses 953 652 -301
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hey @jdevcs i've updated the PR with requested changes, please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
web3 and other libs size change slightly in each release so this will need updates each time, I think this shouldn't part of doc
@deepak2030 if you remove size image we can merge this PR |
Description
This change resolves #6781 by adding an image to compare size of various bundles and including 1 more feature in the "Features of Web3.js v4" section of docs.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.