Compare package size (wihtout image) #6994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantiagoDevRel
requested review from
avkos,
jdevcs,
luu-alex and
Muhammad-Altabba
as code owners
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 4748f64 | Previous: 6c075db | Ratio |
|---|---|---|---|
processingTx |
9048 ops/sec (±4.02%) |
9301 ops/sec (±4.81%) |
1.03 |
processingContractDeploy |
37945 ops/sec (±6.77%) |
39129 ops/sec (±7.62%) |
1.03 |
processingContractMethodSend |
18384 ops/sec (±7.69%) |
19443 ops/sec (±5.19%) |
1.06 |
processingContractMethodCall |
36961 ops/sec (±6.66%) |
38971 ops/sec (±6.34%) |
1.05 |
abiEncode |
40926 ops/sec (±7.31%) |
44252 ops/sec (±6.92%) |
1.08 |
abiDecode |
29731 ops/sec (±6.59%) |
30419 ops/sec (±8.89%) |
1.02 |
sign |
1517 ops/sec (±4.27%) |
1656 ops/sec (±4.08%) |
1.09 |
verify |
366 ops/sec (±0.64%) |
373 ops/sec (±0.78%) |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
Muhammad-Altabba
approved these changes
Apr 23, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6994 +/- ##
==========================================
+ Coverage 87.37% 91.98% +4.61%
==========================================
Files 197 215 +18
Lines 7548 8284 +736
Branches 2059 2273 +214
==========================================
+ Hits 6595 7620 +1025
+ Misses 953 664 -289
Flags with carried forward coverage won't be shown. Click here to find out more.
|
avkos
approved these changes
Apr 23, 2024
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over the PR #6852 and closing the issue #6781