SwiftLint recommends a double run when fixing #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/realm/SwiftLint#xcode recommends > If you wish to fix violations as well, your script could run `swiftlint --fix && swiftlint` instead of just `swiftlint`. This will mean that all correctable violations are fixed while ensuring warnings show up in your project for remaining violations. https://github.com/realm/SwiftLint#auto-correct > Standard linting is disabled while correcting because of the high likelihood of violations (or their offsets) being incorrect after modifying a file while applying corrections.
JeneaVranceanu
previously approved these changes
Feb 22, 2023
|
@cclauss Ping me when you are done with this PR. |
|
Please re-review. |
janndriessen
previously approved these changes
Feb 22, 2023
.swiftlint.yml
Outdated
| force_try: error | ||
| # force warnings (disabled above) | ||
| # force_cast: error | ||
| # force_try: error |
There was a problem hiding this comment.
Do we need these commented out lines?
cclauss
commented
Feb 22, 2023
janndriessen
approved these changes
Feb 25, 2023
|
@JeneaVranceanu wrote:
Ready for review. |
JeneaVranceanu
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/realm/SwiftLint#xcode recommends
https://github.com/realm/SwiftLint#auto-correct
Summary of Changes
Fixes # (if applicable - add the number of issue this PR addresses)
Test Data or Screenshots
By submitting this pull request, you are confirming the following:
developbranch.