Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftLint recommends a double run when fixing #784

Merged
merged 11 commits into from
Feb 27, 2023
Merged

SwiftLint recommends a double run when fixing #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
86b01a3
SwiftLint recommends a double run when fixing
cclauss Feb 22, 2023
3ffeb49
Enable `git diff` in GitHub Actions
cclauss Feb 22, 2023
cf25386
chore: removed obsolete comment
JeneaVranceanu Feb 22, 2023
374bd1d
git diff origin/${GITHUB_REF##*/} origin/${GITHUB_HEAD_REF}
cclauss Feb 22, 2023
6effeb4
git diff origin/develop origin/${GITHUB_HEAD_REF}
cclauss Feb 22, 2023
17e7890
Update macOS-tests.yml
cclauss Feb 22, 2023
dbc1e4b
Update macOS-tests.yml
cclauss Feb 22, 2023
b0ded20
Update macOS-tests.yml
cclauss Feb 22, 2023
e00f053
Update macOS-tests.yml
cclauss Feb 22, 2023
767bb49
Update .swiftlint.yml
cclauss Feb 22, 2023
2df196a
Update .swiftlint.yml
cclauss Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/macOS-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,10 @@ jobs:
codespell # See .codespellrc for args
- name: SwiftLint
run: |
# Adding --fix flag makes CI print only errors that cannot be fixed automatically
swiftlint --fix
# 1. Make all automated fixes that are possible
# 2. git diff to see what (if any) automated fixes were made
# 3. See https://github.com/realm/SwiftLint#xcode explains why the double run
swiftlint --fix --quiet && git diff && swiftlint --quiet
yaroslavyaroslav marked this conversation as resolved.
Show resolved Hide resolved
- name: Resolve dependencies
run: swift package resolve
- name: Build
Expand Down
4 changes: 0 additions & 4 deletions .swiftlint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@ opt_in_rules:
- unneeded_parentheses_in_closure_argument
- weak_delegate

# force warnings
force_cast: error
force_try: error

custom_rules:
commented_out_code:
included: .*\.swift # regex that defines paths to include during linting. optional.
Expand Down